Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding DiskANN Implementation #1042

Open
cdoron opened this issue Jan 19, 2025 · 1 comment
Open

Question regarding DiskANN Implementation #1042

cdoron opened this issue Jan 19, 2025 · 1 comment

Comments

@cdoron
Copy link

cdoron commented Jan 19, 2025

Hi @cydrain,

I am looking at the code for DiskANN https://github.com/zilliztech/knowhere/tree/main/thirdparty .
It appears to me that the code is based on an old version of DiskANN (maybe version 0.2 - https://github.com/microsoft/DiskANN/tree/0.2/src ).

Following my question on Discord, @PwzXxm wrote that "we have done some works like filtering and iterators" on top of DiskANN.

Question: What is the filtering that you have implemented? Are you referring to the label-based filtering from the https://harsha-simhadri.org/pubs/Filtered-DiskANN23.pdf paper, or is it something different altogether?

Thanks! Doron

@liliu-z
Copy link
Collaborator

liliu-z commented Jan 24, 2025

Hi @cdoron, about filtering, same purpose but different implementation, since we did it one year before this paper. Also some small patches that to solve some users' corner cases.

We are more than welcome for any effort try to update our DiskANN implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants