Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes and fixes #52

Open
akatrevorjay opened this issue Oct 28, 2015 · 2 comments
Open

Breaking changes and fixes #52

akatrevorjay opened this issue Oct 28, 2015 · 2 comments

Comments

@akatrevorjay
Copy link
Contributor

Hi, I've been working on quite a few fixes and feature additions in my fork. (Expect more prs soon.)

To meet some requirements of my project I've been modifying some core parts of pyrox lately in my working copy and have introduced breaking api changes. If possible I'd like to push these back up, but if you have a moment I'd like to talk with you about them to see if they are a match to integrate. Are you interested in that? If so, is there someway that would work best?

@zinic
Copy link
Owner

zinic commented Oct 28, 2015

This is awesome news. I've been toying with better error handling from the parser but beyond that I've got nothing new that would impede introduction of your work. I do idle on #pyrox-dev @freenode if you'd like to chat. Otherwise, I'm available on Skype @zinic.vf and a few others.

I have been giving the original model a lot of thought too and some of your changes may obviate the need for future work I had intended. I am excited to see what's cooking :)

-John

@chadlung
Copy link
Collaborator

Sounds exciting overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants