You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The feature request is related to [https://github.com//issues/2039]
It seems that the MR that closed it did not address the symmetical issue on the Server.Config. I see the requirements say: Add an option to directly pass objects of type javax.net.ssl.keyManagerFactory and javax.net.ssl.trustManagerFactory (both for both client and server contexts) . I do not see the server context in that commit.
More specifially we are currently doing something like this with the akka http server creating SslContext and pass it to the akka server which I think is pretty standard (shown below).
def fromConfig(config: KeystoreConfiguration): SSLContext = {
val ks = KeyStore.getInstance(config.`type`)
val keyStream = new FileInputStream(config.file)
ks.load(keyStream, config.password.toCharArray)
val kmf = KeyManagerFactory.getInstance("SunX509")
kmf.init(ks, config.password.toCharArray)
val tmf = TrustManagerFactory.getInstance("SunX509")
tmf.init(ks)
val sslContext: SSLContext = SSLContext.getInstance("TLSv1.2")
sslContext.init(
kmf.getKeyManagers,
tmf.getTrustManagers,
new SecureRandom
)
sslContext
}
Describe the solution you'd like
We would like the symmetrical feature similar to the above mentioned feature but on the server side SSLConfig
Describe alternatives you've considered
For us this is a showstopper to moving from akka. Happy to consider solutions if you have any but we wouldn't want to fork zio-http. Open to submitting a PR ourselves.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The feature request is related to [https://github.com//issues/2039]
It seems that the MR that closed it did not address the symmetical issue on the Server.Config. I see the requirements say:
Add an option to directly pass objects of type javax.net.ssl.keyManagerFactory and javax.net.ssl.trustManagerFactory (both for both client and server contexts) . I do not see the server context in that commit.
More specifially we are currently doing something like this with the akka http server creating SslContext and pass it to the akka server which I think is pretty standard (shown below).
Describe the solution you'd like
We would like the symmetrical feature similar to the above mentioned feature but on the server side
SSLConfig
Describe alternatives you've considered
For us this is a showstopper to moving from akka. Happy to consider solutions if you have any but we wouldn't want to fork zio-http. Open to submitting a PR ourselves.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: