User/zlatnikp/installstep

[pavelzlatnik]

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

• Tests for the changes have been added (for bug fixes / features)
• Necessary documentation (if appropriate) have been added / updated
• DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

• Bugfix
• Feature
• Other... Please describe:

Relevant issues

Fixes #4083

Changes proposed in this PR

1.Based on testing, install step is not only for conv. build.
Documentation is wrong,
https://docs.zowe.org/stable/appendix/zwe_server_command_reference/zwe/zwe-install/
There is statement : If you are using SMPE build, you can skip this command since MVS data sets are already prepared during SMPE install.
But that is not truth, there are created only TARGET libraries of those 4, not runtime libraries which should be used for zowe runtime.

Install step is needed to allocate remaining runtime dataset (not created via PSWI or SMP/E).
Without install step, user have to run zowe from TARGET libraries which were created via PSWI or SMP/E, which is wrong.
Modified in zowe configuration workflow and in API ML configuration workflow.

2.Changed description of zowe_setup_dataset_prefix variable, because it should be runtime prefix (for datasets created by install step), not for Target (target lib should not be used for real run of zowe)

3.Reordered API ML and zowe configuration workflow in pswi, to put API ML before zowe, and change workflow names displayed in PSWI to better describe only one of them should be used.

Does this PR introduce a breaking change?

• Yes
• No

Does this PR do something the person installing Zowe should know about?

Yes, I will create ticket to update zowe documentation, because in places like here
https://docs.zowe.org/stable/user-guide/configure-zowe-zosmf-workflow#3-zowe-installation

https://docs.zowe.org/stable/appendix/zwe_server_command_reference/zwe/zwe-install/
is written install step is only for convenience build, but it is not truth. Without install step, those 4 are not created as runtime datasets
SZWEAUTH contains few Zowe load modules (++PROGRAM).
SZWESAMP contains several sample configurations.
SZWEEXEC contains few utilities used by Zowe.
SZWELOAD contains config manager for REXX.

---

• Affected function: general area of interest *

---

• Description: 1 line description *

---

• Part: name of customizable file involved *

---

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

[github-actions]

build 6891 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13050223167

[github-actions]

Test workflow 6050 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4161/zowe-3.1.0-pr-4161-6891-20250130102406.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13050307967

[MarkAckert]

The PSWI workflow is failing here:

zowe-install-packaging/pswi/scripts/wf_run_test.sh

Line 86 in f605515

if [ "$STEP_NAME" = "init_zowe" ]; then

With this PR, the install step is hit before the init step, and the install step fails. I think this is to be expected - the init step was failing before and the automation would quit out successfully there. I don't know if you want the install to succeed, or if you want to change the expected fail point to install_zowe. Either should fix the build.

[pavelzlatnik]

The PSWI workflow is failing here:

zowe-install-packaging/pswi/scripts/wf_run_test.sh

Line 86 in f605515

if [ "$STEP_NAME" = "init_zowe" ]; then

With this PR, the install step is hit before the init step, and the install step fails. I think this is to be expected - the init step was failing before and the automation would quit out successfully there. I don't know if you want the install to succeed, or if you want to change the expected fail point to install_zowe. Either should fix the build.

you are right, because I modified install to be NOT optional, i need to change the expected fail point to install step instead of init as was until now

[github-actions]

build 6894 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13069523993

[pavelzlatnik]

build 6894 https://github.com/zowe/zowe-install-packaging/actions/runs/13069523993
Run echo "One or more SAMP or EXEC file(s) have changed."
echo "One or more SAMP or EXEC file(s) have changed."
echo "This may require HOLDDATA to be created."
echo "Files changed: $TEST_ALL_CHANGED_FILES"
exit 1
shell: /usr/bin/bash -e {0}
env:
TEST_ALL_CHANGED_FILES: example-zowe.yaml
One or more SAMP or EXEC file(s) have changed.
This may require HOLDDATA to be created.
Files changed: example-zowe.yaml

There was done only change of comment in example zowe yaml, no need to create holddata for this, how to skip this "failure"? @MarkAckert

[github-actions]

Test workflow 6054 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4161/zowe-3.1.0-pr-4161-6894-20250131090518.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13069606911

[MarkAckert]

build 6894 zowe/zowe-install-packaging/actions/runs/13069523993
Run echo "One or more SAMP or EXEC file(s) have changed."
echo "One or more SAMP or EXEC file(s) have changed."
echo "This may require HOLDDATA to be created."
echo "Files changed: $TEST_ALL_CHANGED_FILES"
exit 1
shell: /usr/bin/bash -e {0}
env:
TEST_ALL_CHANGED_FILES: example-zowe.yaml
One or more SAMP or EXEC file(s) have changed.
This may require HOLDDATA to be created.
Files changed: example-zowe.yaml

There was done only change of comment in example zowe yaml, no need to create holddata for this, how to skip this "failure"? @MarkAckert

We just leave the failure and can note somewhere in comment or PR description that no HOLDDATA is required. It's not a required check to merge the PR, it's meant to catch our attention in case we needed HOLDDATA.

[github-actions]

build 6905 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13118213662

[github-actions]

Test workflow 6066 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4161/zowe-3.1.0-pr-4161-6905-20250203164038.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13118364882