-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Zulip Server 5 #268
Comments
(But in general we should avoid introducing more such places for now. As I wrote at #238 (comment) :
) |
When we do this, we should probably express the check in terms of a Zulip feature level, rather than a Zulip Server version in a form like "5.0". See chat discussion. OTOH when the check fails and we're giving an error message to the user, that explanation should probably say the minimum is "Zulip Server 5.0". So for example:
|
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also: 631f4d6 Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also: 631f4d6 Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also: 631f4d6 Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also: 631f4d6 Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also: 631f4d6 Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also commit 631f4d6. Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also commit 631f4d6. Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also commit 631f4d6. Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
See "Feature level 120" from Zulip API changelog: https://zulip.com/api/changelog See also commit 631f4d6. Fixes: zulip#268 Signed-off-by: Zixuan James Li <[email protected]>
Prerequisite for this issue:
Currently the app works with any Zulip Server version 4.x or newer. This is documented in our README and reflects what's documented at https://zulip.readthedocs.io/en/latest/overview/release-lifecycle.html . With #267, we'll start giving an explicit error if the user tries to connect to an older server.
At some point we'll want to increase that minimum to 5.x. As recorded at https://blog.zulip.com/tag/major-releases/ , 4.0 was released in 2021-05, over 2 years ago, and 5.0 in 2022-03, approaching 1.5 years ago.
When we do, we can follow up by sweeping the codebase for
TODO(server-5)
comments and acting on all of those. That will be in the same spirit as zulip/zulip-mobile#5100 and zulip/zulip-mobile#5192 in the old zulip-mobile RN app. (And zulip/zulip-mobile#5708, though that's a draft that was made moot by our migration to Flutter.)There is one spot where we already don't fully support older than server 5.x: currently we ignore user settings on such servers, falling back to defaults. As I wrote at #261 (comment) (reviewing @chrisbobbe's PR which introduced support for user settings and skipped it for those old servers):
The assumption that relies on is that we will desupport server 4.x (or if not then go back and deal with the old settings API after all) before launch.
The text was updated successfully, but these errors were encountered: