-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT100 ZWave thermostats report extra values after reboot #6650
Comments
I think the problem actually happens when ZWave JS restarts. I just changed some of the logging options (to remove the node filtering that I had put in place) and the problem above reproduced again. |
@AlCalzone Seems like the device occasionally reports something it should not, this reminds me to possibile connectivity issues? @ken-wolfe Did you tried to use an usb extension cord? Check this: https://zwave-js.github.io/node-zwave-js/#/troubleshooting/nonsensical-values |
@robertsLando I have not tried a USB extension. I don’t think I’m getting random results. It’s the same thing each time ZWave JS restarts which is then fixed when I re-interview the device. And it happens exactly the same on both of my CT100 thermostats. One of them is about 5 feet from the zwave stick, the other is probably 50 feet away. I started to look through the Zwave JS code over the weekend, but I’m not familiar with it. My first thought was to try to understand how the initial boot / device bring up works as compared to what happens during the re-interview. Like maybe there is some junk stored in the db that isn’t getting refreshed during the re-interview. However, I have no idea how this code actually works, so it might take a while to figure anything out. |
I just reproed the problem by restarting the zwave js ui add on in home assistant. Nothing else is required. Refreshing the zwave js device in home assistant did not reproduce the problem. |
OK let's see what @AlCalzone can tell us when checking logs |
We have quite an extensive set of compat flags to get rid of these additional endpoints, since the device does report them, although they are useless:
The log does not contain such an instance, but I guess the device does report on those endpoints from time to time, and Z-Wave JS doesn't ignore those reports correctly. |
@AlCalzone Is there something I should try? Sorry it’s not clear to me what to do next. |
No, you'll have to wait until I'm back from parental leave. I'll try to reproduce this in a test case, so I can fix it for good. |
Sorry to have bothered you on parental leave. Enjoy the time with your child (or children). If there are any additional logs that would be helpful, I’m happy to gather them. Just let me know. |
It's fine. I check in here when I do have time to kill. |
This should be fixed since v12.5.4 - might need a re-interview though. |
I am on Core Version 2024.4.3, OS 12.2 and continue to have this problem whenever a new version of Z-Wave-JS-UI is installed (perhaps when restarted). After re-interview, the extra entities are unavailable. If I remove the unavailable entities, they reappear with the next Z-Wave-JS-UI update/restart, and I must re-interview all the thermostats again (I have 5 CT101 and CT100). Perhaps I should not remove the unavailable extra entities. Previously reported in #6184 and the fix in #6185 fixed the problem by a re-interview but extra entities still appear after an update/restart. Nothing urgent, just a bother. |
Which version of Z-Wave JS UI are you using? |
zwave-js-ui: 9.10.2 |
Like I said, the fix (#6760) is in version 12.5.4, so you don't have it yet. |
I just updated to z-wave js 12.5.5 and z-wave js ui 9.11.1. After the upgrade completed, the duplicate items were present again. I also tried restarting Home Assistant, and the duplicate items were present. Would you like me to collect logs again? In between the restarts I re-interviewed and removed the zombie items. Also, the zombie items were not present before the upgrade (as I had done the re-interview dance several weeks ago after a different upgrade/restart). |
Ok then I need logs please. |
Here are the logs. I started with system running, and the extra items are deleted. I turned on "Debug" level logging and logged it to a file. The logs should contain the following actions: I restarted Home Assistant. The zombie items came back, I re-interviewed each device and deleted the zombie items after the re-interview. Let me know if you'd like a new bug or any additional logs or information. |
In case it matters, I delete the zombie items from the Home Assistant UI. If I should be removing them from elsewhere, let me know. |
You cannot really delete them, as HA just creates entities for what Z-Wave JS exposes. I need a bit more info I'm afraid.
|
I'm going to follow the directions you provided, but also want to make sure I'm doing the right thing.
I'm assuming this means turn on "Debug" logging in Z-Wave JS. So this is what I have done.
Again, I'm assuming that this is in Z-Wave JS
Same assumption as above, in Z-Wave JS I did it twice, one for each node in case there is something to be learned there. Please let me know if you need any additional things. I'm happy to help. Here is the output for node 5:
|
BTW, running the script in the driver reproduced the issue. |
@AlCalzone do you need any additional information from me? |
Haven't been able to check yet, since I was on a trip last week. |
Just wondering if there are any updates here or if I can help in any way. Thanks! |
Sorry, I have to admit I forgot about this. I still don't fully understand what's happening - I might have to simulate the device and try to figure it out that way. Could you repeat what you did in #6650 (comment), but immediately after re-interviewing the device? One of the two is enough. |
So I've got some good news. I was about to repro the issue (which had repro'd just a few days ago) when I noticed a new update to zwave-js for Home Assistant. I took the update (which would normally cause the issue), but it did not. So, I rebooted the entire system, which would also normally cause the issue to repro, and it did not. So, perhaps the last update for zwave-js did not contain your fix and the one I took today did. I think this can be closed now. |
Hmm according to your logs you should have had the fixed version already. |
Checklist
Deploy method
Home Assistant Add-on
Z-Wave JS UI version
9.8.1
ZwaveJS version
12.4.2
Describe the bug
Occasionally my thermostats (I have 2 of them, both CT100), report extra values (2 additional full thermostats, 1 additional air temp sensor). This seems to happen after rebooting my Home Assistant computer, restarting HA by itself does not seem to trigger the issue. Re-interviewing the node for each thermostat, causes these additional values to get removed.
The log files below are a copy and paste of the Node-JS UI "Debug" screen for node 30, 1 from before I reinterviewed the node and one from after. The after does not contain the extra values.
node30-after-interview.txt
node30-before-interview.txt
Here is a full Driver log from Node-JS UI for node 5 and node 30 (my thermostats) which should show before I re-interviewed, the re-interview, a restart of HA, a reboot of the HA machine (which then causes the problem to repro), and a re-interview of the devices (which removes the problem until the next reboot of the machine).
zwavejs_2024-01-27(1).log
Let me know if there is anything more that you need from me. Now that I know how to reproduce the problem, I should be able to get additional logs very easily.
To Reproduce
Have Home Assistant
Have ZWave-JS UI installed
Re-interview one of the thermostat nodes, notice that extra values go away
Reboot Home Assistant computer
Notice that extra values have returned.
Expected behavior
No extra values for the thermostat nodes appear. There should be only 1 thermostat control per node.
Additional context
Sometimes the extra air temp sensor does not show up. Not sure why that is.
The text was updated successfully, but these errors were encountered: