-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize udmpparser::UserDumpParser::GetMemBlock #17
Conversation
Oof great find - thank you for diagnosing the issue, taking the time to send a PR 🙏🏽 (and sorry for introducing this bug 🫢) Let me work off this PR to fix the CI & update how the Python wheels gets generated.. shouldn't take me too long. Cheers |
Actually, isn't this a bug |
Okay never mind, I read that piece of code too fast - my apologies 😅 Cheers |
All right, if this looks good to you I'll get this merged this weekend 🙂 thank you again! Cheers |
That sounds good. Honestly, you most likely spent more time reading the code than it took me to write it. |
Haha awesome - to be fair, you diagnosed the problem as well :) In any case, thank you again; let's merge this and will keep the thread updated when the Python wheels are up. Cheers |
Okay, v0.6 has been published on pypi:
|
Thanks. |
It works in my testing, let me know if you can find any issues with it. This is significantly faster, has worked in my tooling, and has sped up IAT resolving from 5028ms to 24ms on my machine in my application when profiled.