Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize udmpparser::UserDumpParser::GetMemBlock #17

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

0-x-2-2
Copy link
Contributor

@0-x-2-2 0-x-2-2 commented Nov 13, 2024

It works in my testing, let me know if you can find any issues with it. This is significantly faster, has worked in my tooling, and has sped up IAT resolving from 5028ms to 24ms on my machine in my application when profiled.

@0vercl0k
Copy link
Owner

0vercl0k commented Nov 14, 2024

Oof great find - thank you for diagnosing the issue, taking the time to send a PR 🙏🏽 (and sorry for introducing this bug 🫢)

Let me work off this PR to fix the CI & update how the Python wheels gets generated.. shouldn't take me too long.

Cheers

@0vercl0k
Copy link
Owner

Actually, isn't this a bug if (it != Mem_.begin()) { ? Shouldn't it be Mem_.end() @0-x-2-2 or I am missing something?

@0vercl0k
Copy link
Owner

Okay never mind, I read that piece of code too fast - my apologies 😅

Cheers

@0vercl0k
Copy link
Owner

All right, if this looks good to you I'll get this merged this weekend 🙂 thank you again!

Cheers

@0-x-2-2
Copy link
Contributor Author

0-x-2-2 commented Nov 20, 2024

That sounds good. Honestly, you most likely spent more time reading the code than it took me to write it.

@0vercl0k
Copy link
Owner

Haha awesome - to be fair, you diagnosed the problem as well :)

In any case, thank you again; let's merge this and will keep the thread updated when the Python wheels are up.

Cheers

@0vercl0k 0vercl0k merged commit 169d1c5 into 0vercl0k:main Nov 20, 2024
13 checks passed
@0vercl0k
Copy link
Owner

Okay, v0.6 has been published on pypi:

>pip install udmp_parser
Requirement already satisfied: udmp_parser in c:\users\over\anaconda3\lib\site-packages (0.6.0)
over@panther:~$ pip install udmp_parser
Defaulting to user installation because normal site-packages is not writeable
Collecting udmp_parser
  Downloading udmp_parser-0.6.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (10 kB)
Downloading udmp_parser-0.6.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (235 kB)
Installing collected packages: udmp_parser
Successfully installed udmp_parser-0.6.0

@0-x-2-2
Copy link
Contributor Author

0-x-2-2 commented Nov 21, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants