Merge pull request #1006 from 0x1-company/refactor-activated-godmode

refactor: 💡 activated god mode
0x1-company · Nov 20, 2023 · 770a588 · 770a588
2 parents db2816f + 1cf995f
commit 770a588
Show file tree

Hide file tree

Showing 8 changed files with 40 additions and 70 deletions.
diff --git a/Packages/GodPackage/Package.swift b/Packages/GodPackage/Package.swift
@@ -11,6 +11,7 @@ let package = Package(
   ],
   products: [
     .library(name: "AboutFeature", targets: ["AboutFeature"]),
+    .library(name: "ActivatedGodModeFeature", targets: ["ActivatedGodModeFeature"]),
     .library(name: "ActivityFeature", targets: ["ActivityFeature"]),
     .library(name: "AddFeature", targets: ["AddFeature"]),
     .library(name: "AppFeature", targets: ["AppFeature"]),
@@ -63,6 +64,11 @@ let package = Package(
       .product(name: "SwiftUIMessage", package: "SwiftUIMessage"),
       .product(name: "UIPasteboardClient", package: "CupertinoPackage"),
     ]),
+    .target(name: "ActivatedGodModeFeature", dependencies: [
+      .product(name: "Styleguide", package: "UIComponentPackage"),
+      .product(name: "AnalyticsClient", package: "DependencyPackage"),
+      .product(name: "ComposableArchitecture", package: "swift-composable-architecture"),
+    ]),
     .target(name: "ActivityFeature", dependencies: [
       "ProfileFeature",
     ]),
@@ -174,6 +180,7 @@ let package = Package(
     ]),
     .target(name: "InboxFeature", dependencies: [
       "InboxDetailFeature",
+      "ActivatedGodModeFeature",
     ]),
     .target(name: "InboxStoryFeature", dependencies: [
       .product(name: "God", package: "DependencyPackage"),

diff --git a/...urces/InboxFeature/ActivatedGodMode.swift → ...atedGodModeFeature/ActivatedGodMode.swift b/...urces/InboxFeature/ActivatedGodMode.swift → ...atedGodModeFeature/ActivatedGodMode.swift
diff --git a/Packages/GodPackage/Sources/ActivatedGodModeFeature/Assets.xcassets/Contents.json b/Packages/GodPackage/Sources/ActivatedGodModeFeature/Assets.xcassets/Contents.json
@@ -0,0 +1,6 @@
+{
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/...activated-god-mode.imageset/Contents.json → ...activated-god-mode.imageset/Contents.json b/...activated-god-mode.imageset/Contents.json → ...activated-god-mode.imageset/Contents.json
diff --git a/...-god-mode.imageset/activated-god-mode.svg → ...-god-mode.imageset/activated-god-mode.svg b/...-god-mode.imageset/activated-god-mode.svg → ...-god-mode.imageset/activated-god-mode.svg
diff --git a/Packages/GodPackage/Sources/ActivatedGodModeFeature/Localizable.xcstrings b/Packages/GodPackage/Sources/ActivatedGodModeFeature/Localizable.xcstrings
@@ -0,0 +1,26 @@
+{
+  "sourceLanguage" : "en",
+  "strings" : {
+    "OK" : {
+      "localizations" : {
+        "ja" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "OK"
+          }
+        }
+      }
+    },
+    "Tap a message in your inbox to reveal the sender" : {
+      "localizations" : {
+        "ja" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "自分を褒めてくれた人の名前を見ることができます！"
+          }
+        }
+      }
+    }
+  },
+  "version" : "1.0"
+}
diff --git a/Packages/GodPackage/Sources/InboxFeature/Inbox.swift b/Packages/GodPackage/Sources/InboxFeature/Inbox.swift
@@ -1,3 +1,4 @@
+import ActivatedGodModeFeature
 import AnalyticsClient
 import AnimationDisableTransaction
 import Build

diff --git a/Packages/GodPackage/Sources/InboxFeature/Localizable.xcstrings b/Packages/GodPackage/Sources/InboxFeature/Localizable.xcstrings
@@ -34,23 +34,6 @@
         }
       }
     },
-    "From %@ in %@" : {
-      "extractionState" : "stale",
-      "localizations" : {
-        "en" : {
-          "stringUnit" : {
-            "state" : "new",
-            "value" : "From %1$@ in %2$@"
-          }
-        },
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "%2$@の%1$@があなたを選びました"
-          }
-        }
-      }
-    },
     "From a %@" : {
       "localizations" : {
         "ja" : {
@@ -91,17 +74,6 @@
         }
       }
     },
-    "godapp.jp" : {
-      "extractionState" : "stale",
-      "localizations" : {
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "godapp.jp"
-          }
-        }
-      }
-    },
     "Notifications are off" : {
       "localizations" : {
         "ja" : {
@@ -112,16 +84,6 @@
         }
       }
     },
-    "OK" : {
-      "localizations" : {
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "OK"
-          }
-        }
-      }
-    },
     "See who likes you" : {
       "localizations" : {
         "ja" : {
@@ -132,28 +94,6 @@
         }
       }
     },
-    "See who sent it" : {
-      "extractionState" : "stale",
-      "localizations" : {
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "誰から届いたか見る？👀"
-          }
-        }
-      }
-    },
-    "Share Stories" : {
-      "extractionState" : "stale",
-      "localizations" : {
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "ストーリーでシェアする"
-          }
-        }
-      }
-    },
     "someone" : {
       "localizations" : {
         "ja" : {
@@ -164,16 +104,6 @@
         }
       }
     },
-    "Tap a message in your inbox to reveal the sender" : {
-      "localizations" : {
-        "ja" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "自分を褒めてくれた人の名前を見ることができます！"
-          }
-        }
-      }
-    },
     "Tap anywhere to close" : {
       "localizations" : {
         "ja" : {