Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Improve codebase structure #516

Merged
merged 6 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<p align="center">
<img alt="FluentHub hero image" src="/assets/header.png" />
<img alt="FluentHub hero image" src="./assets/header.png" />
</p>

<p align="center">
Expand Down Expand Up @@ -33,11 +33,11 @@ Looking for a place to start? Check out [the task board](https://github.com/user

## Screenshots

![Screenshot 2024-09-15 104438](https://github.com/user-attachments/assets/1728729b-0c8f-4cdb-aaf4-fbc7643b0bdf)
![PR page screenshot](./assets/screenshots/page-pr.png)

Your dashboard|Your repos|User profile page
---|---|---
![Screenshot 2024-09-15 104352](https://github.com/user-attachments/assets/c6e556c8-9fcb-4bfc-822d-08fde80eec2e)|![Screenshot 2024-09-15 104425](https://github.com/user-attachments/assets/3427a168-5bcc-4ac4-a7f2-761698c28eac)|![Screenshot 2024-09-15 104700](https://github.com/user-attachments/assets/d4ee0f1f-7e7b-4751-abf3-1df65ad16a99)
![Dashboard page screenshot](./assets/screenshots/page-dashboard.png)|![Repo page screenshot](./assets/screenshots/page-repo.png)|![User page screenshot](./assets/screenshots/page-user.png)

## Building the Code

Expand All @@ -52,7 +52,7 @@ git clone https://github.com/FluentHub/FluentHub

### 2. Prepare OAuth credentials

See [the documentation](docs/credentials.md).
See [the documentation](../docs/credentials.md).

> [!WARNING]
> If you skip this step, Visual Studio will give a fatal error that the `AppCredentials.config` file does not exist.
Expand Down
File renamed without changes
File renamed without changes
File renamed without changes
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved
File renamed without changes
Binary file added .github/assets/screenshots/page-dashboard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .github/assets/screenshots/page-pr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .github/assets/screenshots/page-repo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .github/assets/screenshots/page-user.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 3 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@ on:
branches:
- main
paths-ignore:
- 'assets/**'
- 'builds/**'
- '.github/assets/**'
- 'docs/**'
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved
- '*.md'
pull_request:
paths-ignore:
- 'assets/**'
- 'builds/**'
- '.github/assets/**'
- 'docs/**'
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved
- '*.md'

Expand Down Expand Up @@ -133,7 +131,7 @@ jobs:

- if: env.CONFIGURATION == env.AUTOMATED_TESTS_CONFIGURATION && env.ARCHITECTURE == env.AUTOMATED_TESTS_ARCHITECTURE
name: Create self signed cert as a pfx file
run: ./scripts/Generate-SelfCertPfx.ps1 -Destination "$env:APPX_SELFSIGNED_CERT_PATH"
run: ./.github/scripts/Generate-SelfCertPfx.ps1 -Destination "$env:APPX_SELFSIGNED_CERT_PATH"

- if: env.CONFIGURATION == env.AUTOMATED_TESTS_CONFIGURATION && env.ARCHITECTURE == env.AUTOMATED_TESTS_ARCHITECTURE
name: Build & package Files
Expand Down
3 changes: 1 addition & 2 deletions FluentHub.sln
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

Microsoft Visual Studio Solution File, Format Version 12.00
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.0.32014.148
MinimumVisualStudioVersion = 10.0.40219.1
Expand Down
20 changes: 0 additions & 20 deletions docs/CONTRIBUTING.md
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

26 changes: 0 additions & 26 deletions docs/code-style.md
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

21 changes: 0 additions & 21 deletions docs/translations.md
0x5bfa marked this conversation as resolved.
Show resolved Hide resolved

This file was deleted.

10 changes: 10 additions & 0 deletions src/FluentHub.Package/FluentHub.Package.wapproj
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="Current" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<PropertyGroup Condition="'$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '17.0'">
<VisualStudioVersion>17.0</VisualStudioVersion>
</PropertyGroup>

<PropertyGroup>
<TargetPlatformVersion>10.0.22621.0</TargetPlatformVersion>
<TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
Expand All @@ -24,6 +26,7 @@
<EntryPointProjectUniqueName>..\FluentHub.App\FluentHub.App.csproj</EntryPointProjectUniqueName>
<AppxBundle>Always</AppxBundle>
</PropertyGroup>

<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|x86">
<Configuration>Debug</Configuration>
Expand Down Expand Up @@ -62,27 +65,34 @@
<Platform>ARM64</Platform>
</ProjectConfiguration>
</ItemGroup>

<PropertyGroup>
<WapProjPath Condition="'$(WapProjPath)'==''">$(MSBuildExtensionsPath)\Microsoft\DesktopBridge\</WapProjPath>
<PathToXAMLWinRTImplementations>FluentHub.App\</PathToXAMLWinRTImplementations>
</PropertyGroup>

<Import Project="$(WapProjPath)\Microsoft.DesktopBridge.props" />

<ItemGroup>
<AppxManifest Include="Package.appxmanifest">
<SubType>Designer</SubType>
</AppxManifest>
<Content Include="Assets\AppTiles\**" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\FluentHub.App\FluentHub.App.csproj">
<SkipGetTargetFrameworkProperties>True</SkipGetTargetFrameworkProperties>
<PublishProfile>Properties\PublishProfiles\win-$(Platform).pubxml</PublishProfile>
<TrustLevel>Partial</TrustLevel>
</ProjectReference>
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.3.230724000" IncludeAssets="build" />
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" IncludeAssets="build" />
</ItemGroup>

<Import Project="$(WapProjPath)\Microsoft.DesktopBridge.targets" />

</Project>
Loading