add check for SafeSub

0xPolygon · Jan 16, 2025 · 0bb18b7 · 0bb18b7
1 parent 69a02b6
commit 0bb18b7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/x/gov/keeper/deposit.go b/x/gov/keeper/deposit.go
@@ -352,7 +352,11 @@ func (keeper Keeper) DistributeAndDeleteDeposits(ctx context.Context, proposalID
 
 	// Calculate any remaining amount due to truncating issues
 	usedAmount := amountPerValidator.MulInt(sdkmath.NewInt(int64(numValidators)))
-	remainingAmount, _ := totalDeposits.SafeSub(usedAmount...)
+	remainingAmount, isNegative := totalDeposits.SafeSub(usedAmount...)
+	if isNegative {
+		keeper.Logger(ctx).Error("subtraction resulted in a negative amount", "totalDeposits", totalDeposits, "usedAmount", usedAmount)
+		return fmt.Errorf("subtraction resulted in a negative amount")
+	}
 
 	if !remainingAmount.IsZero() {
 		// Send remaining amount to the first validator