Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update miden-assembly to next #68

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

bitwalker
Copy link
Contributor

NOTE: This is intended to be merged after #65.

This updates our miden-assembly dependency, and handles all of the changes to the instruction set, as well as cleans up a few places that were hacky because of missing APIs in miden-assembly.

There are still a couple changes to make once this is merged (fleshing out support for indirect calls and assertions with error codes; creating .masl files when requested), but I'll do that separately to keep this PR smaller.

@bitwalker bitwalker requested a review from greenhat November 18, 2023 02:39
@bitwalker bitwalker self-assigned this Nov 18, 2023
Copy link
Contributor

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

hir/src/asm/builder.rs Outdated Show resolved Hide resolved
hir/src/asm/isa.rs Outdated Show resolved Hide resolved
hir/src/asm/isa.rs Outdated Show resolved Hide resolved
@bitwalker bitwalker force-pushed the bitwalker/attributes branch from d58c736 to e3b09e8 Compare November 20, 2023 18:03
@bitwalker bitwalker force-pushed the bitwalker/update-miden-assembly branch from d23f51f to ef75bd7 Compare November 20, 2023 18:11
Base automatically changed from bitwalker/attributes to main November 20, 2023 18:12
@bitwalker bitwalker force-pushed the bitwalker/update-miden-assembly branch from 3ad0469 to 764b75f Compare November 20, 2023 18:18
@bitwalker bitwalker merged commit 883c6f3 into main Nov 20, 2023
1 check passed
@bitwalker bitwalker deleted the bitwalker/update-miden-assembly branch November 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants