-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/3] Wasm CM support in frontend-wasm. Parse Wasm CM. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
changed the title
[3/3] Wasm CM support in frontend-wasm. Parse Wasm component.
[3/3] Wasm CM support in frontend-wasm. Parse Wasm CM.
Jan 8, 2024
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
from
January 9, 2024 04:19
26a9f7b
to
e244828
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr3-parse-cm
branch
from
January 9, 2024 04:19
213df70
to
034b4b8
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
branch
from
January 9, 2024 08:18
e244828
to
fb8aca3
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr3-parse-cm
branch
from
January 9, 2024 08:18
034b4b8
to
6cc007e
Compare
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr3-parse-cm
branch
from
January 10, 2024 13:32
b18cd08
to
16541a9
Compare
@bitwalker I'm almost done (one cosmetic refactor left - see desc). So it's ready for a preliminary review. |
greenhat
force-pushed
the
greenhat/i80-wasm-cm-pr3-parse-cm
branch
from
January 11, 2024 08:56
519aa1e
to
5aafac8
Compare
bitwalker
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work! Looking forward to getting all this into a place where we can really use it in anger :)
Base automatically changed from
greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build
to
main
January 16, 2024 08:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80
Close #88
This PR is the third in the stacked PRs and should be merged after #84
This PR implements the parsing of Wasm CM and rewrites Wasm core module parsing and translation to support core modules as part of the CM as well as standalone Wasm module binaries.
The translation of the Wasm CM will be implemented in subsequent PRs.