Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3] Wasm CM support in frontend-wasm. Parse Wasm CM. #87

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

greenhat
Copy link
Contributor

@greenhat greenhat commented Jan 8, 2024

#80
Close #88

This PR is the third in the stacked PRs and should be merged after #84

This PR implements the parsing of Wasm CM and rewrites Wasm core module parsing and translation to support core modules as part of the CM as well as standalone Wasm module binaries.

The translation of the Wasm CM will be implemented in subsequent PRs.

@greenhat greenhat changed the title [3/3] Wasm CM support in frontend-wasm. Parse Wasm component. [3/3] Wasm CM support in frontend-wasm. Parse Wasm CM. Jan 8, 2024
@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build branch from 26a9f7b to e244828 Compare January 9, 2024 04:19
@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr3-parse-cm branch from 213df70 to 034b4b8 Compare January 9, 2024 04:19
@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build branch from e244828 to fb8aca3 Compare January 9, 2024 08:18
@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr3-parse-cm branch from 034b4b8 to 6cc007e Compare January 9, 2024 08:18
@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr3-parse-cm branch from b18cd08 to 16541a9 Compare January 10, 2024 13:32
@greenhat
Copy link
Contributor Author

@bitwalker I'm almost done (one cosmetic refactor left - see desc). So it's ready for a preliminary review.

@greenhat greenhat force-pushed the greenhat/i80-wasm-cm-pr3-parse-cm branch from 519aa1e to 5aafac8 Compare January 11, 2024 08:56
@greenhat greenhat marked this pull request as ready for review January 11, 2024 09:53
@greenhat greenhat requested a review from bitwalker January 11, 2024 09:53
@greenhat greenhat linked an issue Jan 12, 2024 that may be closed by this pull request
Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work! Looking forward to getting all this into a place where we can really use it in anger :)

Base automatically changed from greenhat/i80-wasm-cm-pr2-integ-tests-lazy-ir-build to main January 16, 2024 08:55
@bitwalker bitwalker merged commit 5d5537a into main Jan 16, 2024
1 check passed
@bitwalker bitwalker deleted the greenhat/i80-wasm-cm-pr3-parse-cm branch January 16, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Wasm component model
2 participants