Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplesmt: simplify duplicate check #224

Merged
merged 1 commit into from
Nov 28, 2023
Merged

simplesmt: simplify duplicate check #224

merged 1 commit into from
Nov 28, 2023

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

As per the PR title.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@hackaugusto hackaugusto requested a review from bobbinth November 22, 2023 16:11
@hackaugusto hackaugusto force-pushed the hacka-simplesmt-simplify-duplicate-check branch from be90773 to 8a8bf63 Compare November 22, 2023 16:12
@hackaugusto hackaugusto force-pushed the hacka-simplesmt-simplify-duplicate-check branch from 8a8bf63 to 2a7602b Compare November 23, 2023 13:36
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bobbinth
bobbinth approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 3b85fc4 into next Nov 28, 2023
11 checks passed
@bobbinth bobbinth deleted the hacka-simplesmt-simplify-duplicate-check branch November 28, 2023 20:12
@bobbinth bobbinth mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackaugusto @bobbinth