New padding rule for RPX #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of comments inline.
I have kept the old padding rule when hashing bytes so as to avoid the security degradation. On the other hand, there is also a case for uniformity so maybe we should also change it to the new padding rule.
I'm actually not sure if the old padding rule works as intended here - but if it does, we should be able to modify it in the same way and security would go down by the same 3 bits (i.e., to 125 bits), right?
Al-Kindi-0
force-pushed
the
al-new-padding-rule
branch
from
76a82ea to
4c27ebe
Compare
bobbinth
reviewed
Jan 5, 2024
bobbinth
reviewed
Jan 17, 2024
bobbinth
reviewed
Jan 17, 2024
|
bobbinth
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
bobbinth
pushed a commit
that referenced
this pull request
Feb 14, 2024
* feat: new padding rule for RPX * fix: documentation on security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses #203
I have kept the old padding rule when hashing bytes so as to avoid the security degradation. On the other hand, there is also a case for uniformity so maybe we should also change it to the new padding rule.
Checklist before requesting a review
nextaccording to naming convention.