Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falcon-512 from sk to pk #239

Closed
wants to merge 43 commits into from
Closed

Falcon-512 from sk to pk #239

wants to merge 43 commits into from

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

This PR adds the ability to generate the public key, in bytes, from the raw secret key.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth and others added 30 commits October 19, 2023 12:16
@bobbinth
chore: update crate version to v0.8
fd3888a
@hackaugusto @bobbinth
config: add .editorconfig
c2853a5
@bobbinth
chore: update main readme
3830843
@Al-Kindi-0
chore: bump winterfell release to .7
ce4abe2
@hackaugusto
rpo: added conversions for digest
739febf
@hackaugusto
Merge pull request #202 from 0xPolygonMiden/hacka-rpo-digest-conversions
9f6c605 
rpo: added conversions for digest
@Al-Kindi-0 @bobbinth
feat: RPX (xHash12) hash function implementation
977638b
@Al-Kindi-0 @bobbinth
docs: added RPX benchmarks
f59b481
@bobbinth
Merge pull request #201 from 0xPolygonMiden/al-rpx-hash
539dbfa 
RPX hash function
@bobbinth
docs: update changelog
3a6d31d
@hackaugusto
mmr: support arbitrary from/to delta updates
7038685
@hackaugusto
mmr: support proofs with older forest versions
7d3aed0
@hackaugusto
mmr: publicly export MmrDelta
0f90589
@bobbinth
Merge pull request #207 from 0xPolygonMiden/hacka-export-mmr-delta
4812403 
mmr: publicly export MmrDelta
@bobbinth
Merge pull request #205 from 0xPolygonMiden/hacka-mmr-arbitrary-delta
6251453 
mmr: support arbitrary from/to delta updates
@bobbinth
Merge pull request #206 from 0xPolygonMiden/hacka-mmr-proofs-for-olde…
1c2cb1b 
…r-versions

mmr: support proofs with older forest versions
@bobbinth
docs: update bench readme
dc20a00
@bobbinth
Merge pull request #200 from 0xPolygonMiden/al-new-winterfell
8683429 
Bump winterfell release to .7
@bobbinth
chore: update changelog
806e48b
@hackaugusto
mmr: support accumulator of older forest versions
0ce53c4
@hackaugusto
Merge pull request #210 from 0xPolygonMiden/hacka-mmr-accumulator-old…
9a24daa 
…-forest

mmr: support accumulator of older forest versions
@hackaugusto
bugfix: TSMT failed to verify empty word for depth 64.
cf2ab49 
When a prefix is pushed to the depth 64, the entry list includes only
the values different than ZERO. This is required, since each block
represents a 2^192 values.

The bug was in the proof membership code, that failed to handle the case
of a key that was not in the list, because the depth is 64 and the value
was not set.
@hackaugusto
simple_smt: reduce serialized size, use static hashes of the empty word
897ec6c
@hackaugusto
mmr: add into_parts for the peaks
e4c3367
@hackaugusto
Merge pull request #213 from 0xPolygonMiden/hacka-simple_smt-use-stat…
84a26b6 
…ic-data

simple_smt: reduce serialized size, use static hashes of the empty word
@hackaugusto
Merge pull request #214 from 0xPolygonMiden/hacka-mmr-peaks-into-parts
b677952 
mmr: add into_parts for the peaks
@plafer
Consuming iterator for RpoDigest
28a2255
@plafer
Merge pull request #216 from 0xPolygonMiden/plafer-digest-iter
9f0aaf6 
Implement `IntoIterator` for `RpoDigest`
@austinabell
feat: memoize Signature polynomial decoding
2279a5f
@bobbinth
Merge pull request #219 from austinabell/mem_sig
481f801 
feat: memoize Signature polynomial decoding
hackaugusto and others added 12 commits November 22, 2023 17:02
@hackaugusto
simplesmt: bugfix, index must be validated before modifying the tree
b848880
@bobbinth
Merge pull request #223 from 0xPolygonMiden/hacka-simplesmt-invalid-i…
7cd5b25 
…ndex-bug

simplesmt: bugfix, index must be validated before modifying the tree
@hackaugusto
simplesmt: simplify duplicate check
2a7602b
@plafer
Introduce SimpleSmt::with_contiguous_leaves() (#227)
5f48be8 
* with_contiguous_leaves

* test
@bobbinth
Merge pull request #224 from 0xPolygonMiden/hacka-simplesmt-simplify-…
3b85fc4 
…duplicate-check

simplesmt: simplify duplicate check
@plafer
Remove ExactSizeIterator constraint from SimpleSmt::with_leaves() (…
a7791b4 
…#228)

* Change InvalidNumEntries error

* max computation

* remove length check

* remove ExactSizeIterator constraint

* fix InvalidNumEntries error condition

* 2_usize
@plafer
MmrPeaks::hash_peaks() returns Digest (#230)
e87f98d
@hackaugusto
Merge pull request #212 from 0xPolygonMiden/hacka-tsmt-bug-fix-empty-…
801befa 
…value-depth-64

bugfix: TSMT failed to verify empty word for depth 64.
@plafer
Implement SimpleSmt::set_subtree (#232)
9b4430f 
* recompute_nodes_from_indeX_to_root

* MerkleError variant

* set_subtree

* test_simplesmt_set_subtree

* test_simplesmt_set_subtree_entire_tree

* test

* set_subtree: return root
@hackaugusto
serde: for MerklePath, ValuePath, and RootPath
a4d211d
@hackaugusto
Merge pull request #231 from 0xPolygonMiden/hacka-serde-merklepath
57f902c 
serde: for MerklePath, ValuePath, and RootPath
@Al-Kindi-0
feat: add generation of pk from sk
c1c3036
@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth December 19, 2023 15:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bobbinth
Copy link
Contributor

Superseded by #285.

@bobbinth bobbinth closed this Mar 22, 2024
@bobbinth bobbinth deleted the al-falcon-pk-from-sk branch October 18, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth Awaiting requested review from bobbinth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Al-Kindi-0 @bobbinth @hackaugusto @plafer @austinabell