Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check for unused dependencies #625

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

Mirko-von-Leipzig
Copy link
Contributor

This PR adds CI job to reject unused dependencies using cargo machete.

In addition this PR also removes two unused dependencies.

@Mirko-von-Leipzig
Copy link
Contributor Author

Note that there is also cargo-udeps which is a similar tool. Neither is 100% correct, but machete at least has a github action.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

We should probably propagate this to other repos: cc @PhilippGackstatter, @plafer, @igamigo.

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit c5da1e6 into next Jan 16, 2025
10 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/ci/unused-deps branch January 16, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants