Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use miden-objects's BlockNumber #632

Merged
merged 3 commits into from
Jan 21, 2025
Merged

refactor: Use miden-objects's BlockNumber #632

merged 3 commits into from
Jan 21, 2025

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Jan 20, 2025

Uses latest revision of miden-base's next. Also removes local type aliases.

@igamigo igamigo marked this pull request as ready for review January 20, 2025 19:35
@igamigo
Copy link
Collaborator Author

igamigo commented Jan 20, 2025

Ran the client integration tests from this branch, can confirm they are all passing.

@igamigo igamigo requested review from bobbinth, Mirko-von-Leipzig and polydez and removed request for bobbinth January 20, 2025 19:49
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one non-blocking comment inline.

crates/store/src/genesis.rs Outdated Show resolved Hide resolved
crates/block-producer/src/block_builder/mod.rs Outdated Show resolved Hide resolved
crates/block-producer/src/mempool/tests.rs Outdated Show resolved Hide resolved
crates/store/src/genesis.rs Outdated Show resolved Hide resolved
@igamigo igamigo merged commit e8f8314 into next Jan 21, 2025
9 checks passed
@igamigo igamigo deleted the igamigo-block-num branch January 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants