-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: taplo fmt check for TOML files #645
ci: taplo fmt check for TOML files #645
Conversation
e36afb5
to
8015ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbinth in terms of styling, are there any options that catch your eye? I propose adding a [formatting]
align_entries = true # This might not be nice; will have to judge after I see it.
column_width = 120
reorder_keys = true
reorder_arrays = true
reorder_inline_tables = true Mostly just alphabetical ordering to ensure consistency. Might end up looking bad; note that deps could still be grouped together via newlines. Something else that's nice is that taplo provides an LSP which is nice for dev work. |
7a4deb2
to
dcaefc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one small change; the rest looks great
8ed84ca
to
277412d
Compare
Co-authored-by: Mirko <[email protected]>
Closes #644