Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update itertools and axum versions #646

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

sergerad
Copy link

Closes #642

  • Updates itertools and axum dependancy versions
  • Adds itertools as a workspace dependancy

Noting that rusqlite must remain at 0.32.1 due to deadpool-sqlite's version requirements here.

╰─➤  cargo upgrades
miden-node-store
dependency  current  upgrade
rusqlite    0.32.1   0.33.0

Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes itself are good. Some downsides are that we have multiple versions of axum et al in our lockfile now because tonic is still using the previous version.

Some extra compile time or we could wait for tonic to upgrade. Though I don't mind much either way.

@sergerad sergerad changed the title Sergerad/dep updates Update itertools and axum versions Jan 28, 2025
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

Some downsides are that we have multiple versions of axum et al in our lockfile now because tonic is still using the previous version.

I think this is OK (or at least I don't see big downsides to this).

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 4850828 into 0xPolygonMiden:next Jan 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants