Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open-telemetry exporter #660

Merged
merged 2 commits into from
Feb 3, 2025
Merged

feat: open-telemetry exporter #660

merged 2 commits into from
Feb 3, 2025

Conversation

Mirko-von-Leipzig
Copy link
Contributor

This PR adds a --open-telemetry flag to the node's start command. This exports traces to an open-telemetry backend.

The various settings of this exporter can be controlled by the various environment variables specified by the standard e.g.

export OTEL_EXPORTER_OTLP_ENDPOINT="https://api.honeycomb.io"

sets the target endpoint.

This is just initial support for this; our actual traces are still very non-conforming to the standard.

@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review January 31, 2025 15:24
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/otel branch 2 times, most recently from 62f777a to 71f1e33 Compare January 31, 2025 15:27
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title feat: open-telemtry exporter feat: open-telemetry exporter Jan 31, 2025
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of small comments inline.

crates/utils/Cargo.toml Outdated Show resolved Hide resolved
crates/utils/Cargo.toml Outdated Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit ab0701d into next Feb 3, 2025
11 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/otel branch February 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants