[fix]: VerifyCmd Flag Collision #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 18, 2024
|
Hi @varun-doshi - any interest in pushing this PR over the finish line? |
Hi yes apologies for the delay |
bobbinth
reviewed
Nov 23, 2024
bobbinth
reviewed
Nov 28, 2024
miden/src/cli/verify.rs
Outdated
Comment on lines
79
to
88
| let base_name = proof_file.file_stem().expect("Invalid proof file").to_str().unwrap(); | ||
|
|
||
| let input_file = self.input_file.clone().unwrap_or_else(|| { | ||
| let mut input_path = | ||
| proof_file.parent().unwrap_or_else(|| Path::new(".")).to_path_buf(); | ||
| input_path.push(base_name); | ||
| input_path.set_extension("inputs"); | ||
| // input_path.push(format!("{}.inputs", base_name)); | ||
| input_path | ||
| }); |
There was a problem hiding this comment.
Why do we need to first to get the base name and then modify it. Would something like this not work?:
let input_file = self.input_file.unwrap_or_else(|| {
let mut input_path = proof_file.clone();
input_path.set_extension("inputs");
input_path
});There was a problem hiding this comment.
You are right. This makes the code more compact.
Have made the necessary changes
|
After edits and discussions, the verify cmd works as such: |
bobbinth
approved these changes
Nov 28, 2024
bobbinth
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related #1421
This PR does the following:
program-hashto-x. No long forminfer_defaultsfunction which checks the directory specified by the input file passed(with-i) to search for a.proofand.outputsfile (only if these files are not already specified) . If these files are already specified by user, then it does not run this check.Hence the command can be called as such:
as well as such:
TODO:
Checklist before requesting a review
nextaccording to naming convention.