Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EqHash to MastNodeFingerprint #1539

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Rename EqHash to MastNodeFingerprint #1539

merged 5 commits into from
Oct 29, 2024

Conversation

PhilippGackstatter
Copy link
Contributor

Describe your changes

Renames EqHash to MastNodeFingerprint as a follow-up to #1534 and moves the fingerprint to its own module.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@PhilippGackstatter PhilippGackstatter added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Oct 21, 2024
bobbinth
bobbinth approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left just one small comment inline.

core/src/mast/node_fingerprint.rs Outdated Show resolved Hide resolved
@PhilippGackstatter PhilippGackstatter force-pushed the pgackst-mast-forest-merge branch from 032bce5 to 9d5400f Compare October 25, 2024 12:59
@PhilippGackstatter PhilippGackstatter force-pushed the pgackst-mast-node-fingerprint branch from 6605f3b to 563d288 Compare October 28, 2024 08:55
Base automatically changed from pgackst-mast-forest-merge to next October 28, 2024 14:49
@PhilippGackstatter PhilippGackstatter force-pushed the pgackst-mast-node-fingerprint branch from c86ad72 to 16475fb Compare October 28, 2024 15:21
bobbinth
bobbinth approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@PhilippGackstatter PhilippGackstatter merged commit db71e28 into next Oct 29, 2024
9 checks passed
@PhilippGackstatter PhilippGackstatter deleted the pgackst-mast-node-fingerprint branch October 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippGackstatter @bobbinth