You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small PR fixes a bug in the Program deserialization.
It also adds some integration tests to check the correctness of the serialization and deserialization of the Program structure.
The main question is where we should locate the tests for the Program serde.
I think that it would be better to construct the Program from source string to make sure we don't have any bug on the stage of creation of the original Program instance, but in that case we should be able to use Assembler and test-utils. I decided to put tests in the miden integration tests folder, but not sure that this is the best option.
The main question is where we should locate the tests for the Program serde.
I think that it would be better to construct the Program from source string to make sure we don't have any bug on the stage of creation of the original Program instance, but in that case we should be able to use Assembler and test-utils. I decided to put tests in the miden integration tests folder, but not sure that this is the best option.
Essentially we are testing the functionality of the Program structure, which is part of the core, so it's strange for me to add tests to the assembly. But it is strange to add it anywhere, so probably we just should chose where it will suit better. I can move it to the assembly if you think that it will be better.
Essentially we are testing the functionality of the Program structure, which is part of the core, so it's strange for me to add tests to the assembly. But it is strange to add it anywhere, so probably we just should chose where it will suit better. I can move it to the assembly if you think that it will be better.
Agreed that ideally it should be in core - but I think putting it into assembly simplifies testing - so, let's put it there.
no changelogThis PR does not require an entry in the `CHANGELOG.md` file
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fumuran
added
the
no changelog
This small PR fixes a bug in the
Programdeserialization.It also adds some integration tests to check the correctness of the serialization and deserialization of the
Programstructure.