chore: add the string that failed validation to IdentError::InvalidChars error variant
#1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
added
the
no changelog
plafer
reviewed
Oct 30, 2024
plafer
reviewed
Oct 30, 2024
assembly/src/ast/procedure/name.rs
Outdated
Comment on lines
320
to
321
| // Err(IdentError::InvalidChars { ident: s.into() }) | ||
| panic!("IdentError::InvalidChars") |
There was a problem hiding this comment.
I think you forgot to uncomment the Err here right? i.e. we shouldn't be panicking, and returning an error instead
There was a problem hiding this comment.
@greenhat - let's fix this issue and merge. This way, we can include this PR into the next release of miden-vm (which I'm hoping to do on Monday).
There was a problem hiding this comment.
Thanks for catching this! Fixed.
Sorry, I should've picked it up earlier. I botched my email filter for github notifications and missed it.
…hars` error variant
greenhat
force-pushed
the
greenhat/indenterror-invalidchars-add-str
branch
from
1ebd196 to
def81b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add the string that failed validation to
IdentError::InvalidCharserror variant to see the failed string in the error message.Checklist before requesting a review
nextaccording to naming convention.