Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Falcon DSA verification procedure #1623

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Improve Falcon DSA verification procedure #1623

wants to merge 5 commits into from
+281 −85

Conversation

Al-Kindi-0
Copy link
Collaborator

Reduces the cycle count of the Falcon DSA signature verification procedure. This brings the total cycle count to less than 71000 cycles.
Once/if horner_eval_base is implemented, we can bring down this to hopefully 61000 cycles by removing the need for the powers_of_tau and set_to_zero procedures.

plafer
plafer reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few nits

processor/src/operations/sys_ops/sys_event_handlers.rs Outdated Show resolved Hide resolved
stdlib/asm/crypto/dsa/rpo_falcon512.masm Outdated Show resolved Hide resolved
stdlib/asm/crypto/dsa/rpo_falcon512.masm Outdated Show resolved Hide resolved
stdlib/tests/crypto/falcon.rs Outdated Show resolved Hide resolved
@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Jan 19, 2025
Draft
plafer
plafer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al-Kindi-0 @plafer