feat: configurable nightly optimizations #1655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaMasych
force-pushed
the
feat/stable-via-cfg
branch
from
db6fa84 to
d6f34e1
Compare
NikitaMasych
force-pushed
the
feat/stable-via-cfg
branch
from
d6f34e1 to
7e779ed
Compare
|
@Nashtare @LindaGuiga would appreciate your thoughts on this and #1654, as soon as you have time, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #1638
Details
Nightlyis required due to reliance onspecializationfeature, which allows keeping default implementation but leverage more optimized algorithms for specific fields. However, considering this is more desirable than critical, this PR elevates the requirement for nightly toolchain, allowing usage of the library instablemode with, likely, worsened performance.