Update Rust version #1739
Open
Update Rust version #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,4 +23,7 @@ rkyv-serialization = [] | |||
| sha2 = [] | |||
| static-mem-access = [] | |||
| token = [] | |||
| # Not sure whether token, tokenbin, wallet and walletbin should all be here, or whether we forget cleaning them up in recent renames? | |||
There was a problem hiding this comment.
Not sure whether token, tokenbin, wallet and walletbin should all be here, or whether we forget cleaning them up in recent renames?
@supragya You recently did some renames / cleanups here. Do you have an opinion?
There was a problem hiding this comment.
Those should be needed for testing I hope?
| @@ -47,35 +47,28 @@ const CRATES: &[Crate] = &[ | |||
| const CARGO_MANIFEST_DIR: &str = env!("CARGO_MANIFEST_DIR"); | |||
|
|
|||
| fn build_elf(dest: &mut File, crate_path: &str, elf_path: &str, glob_name: &str, uses_std: bool) { | |||
| // Use a dummy array for clippy, since not building the elf is faster than | |||
| // building the elf | |||
| if cfg!(feature = "cargo-clippy") { | |||
There was a problem hiding this comment.
@Daniel-Aaron-Bloom The new version's linter doesn't like this. Do you know whether this ever worked (and perhaps how to repair it)?
|
The update to the new Rust version itself isn't critical, but we can fix the lint issues anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix new linter complaints.