-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up NPM dependencies and update node to v20 #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The E2E Build workflow is logging a node 16 deprecation error, it would be good to update while working on node fixes.
The E2E tests are failing in the WP Minimum tests. The same is happening on trunk so I suspect this expected due to a class change on the snackbar component. It's looking for .components-snackbar
.
Other notes:
npm run build
works successfully- wp-env: starts, stops and destroy work as expected
- cypress: runs locally and in e2e workflows
I'm on OS this week so can have a look at the merge conflicts and workflows.
webpack.config.js
Outdated
externals: { | ||
'@wordpress/plugins': 'wp.plugins', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't required as it's handled by the @wordpress/dependency-extraction-webpack-plugin
in wp-scripts.
95f7e4e
to
e37a726
Compare
@jeffpaul I've bumped a bunch of actions to avoid Node deprecation warnings. In some cases I couldn't as they are using other repos that either define an out of date node version. It looks like the upload-artifact/download-artifact versions will need to be updated in sync across all our repos as v3 uploads are incompatible with v4 downloads. |
@peterwilsoncc is this PR otherwise approved to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffpaul Yep, otherwise looks good.
Description of the Change
This PR cleans up NPM dependencies and updates the node version to
20.11.0
Closes #274
Changelog Entry
Credits
Props @Sidsector9
Checklist: