Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up NPM dependencies and update node to v20 #275

Merged
merged 12 commits into from
May 14, 2024
Merged

Conversation

Sidsector9
Copy link
Member

Description of the Change

This PR cleans up NPM dependencies and updates the node version to 20.11.0
Closes #274

Changelog Entry

Changed - Clean up NPM dependencies and update node to v20

Credits

Props @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested a review from a team as a code owner February 5, 2024 02:58
@Sidsector9 Sidsector9 requested review from peterwilsoncc and removed request for a team February 5, 2024 02:58
@github-actions github-actions bot added this to the 1.8.0 milestone Feb 5, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 5, 2024
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The E2E Build workflow is logging a node 16 deprecation error, it would be good to update while working on node fixes.

The E2E tests are failing in the WP Minimum tests. The same is happening on trunk so I suspect this expected due to a class change on the snackbar component. It's looking for .components-snackbar.

Other notes:

  • npm run build works successfully
  • wp-env: starts, stops and destroy work as expected
  • cypress: runs locally and in e2e workflows

I'm on OS this week so can have a look at the merge conflicts and workflows.

package-lock.json Outdated Show resolved Hide resolved
Comment on lines 58 to 60
externals: {
'@wordpress/plugins': 'wp.plugins',
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't required as it's handled by the @wordpress/dependency-extraction-webpack-plugin in wp-scripts.

@Sidsector9 Sidsector9 requested a review from jeffpaul as a code owner February 12, 2024 03:08
@peterwilsoncc
Copy link
Contributor

@jeffpaul I've bumped a bunch of actions to avoid Node deprecation warnings. In some cases I couldn't as they are using other repos that either define an out of date node version.

It looks like the upload-artifact/download-artifact versions will need to be updated in sync across all our repos as v3 uploads are incompatible with v4 downloads.

@Sidsector9 Sidsector9 modified the milestones: 1.8.0, 1.8.1 Apr 8, 2024
@jeffpaul jeffpaul requested a review from peterwilsoncc May 13, 2024 17:56
@jeffpaul
Copy link
Member

@peterwilsoncc is this PR otherwise approved to merge?

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul Yep, otherwise looks good.

@jeffpaul jeffpaul merged commit ab00d8f into develop May 14, 2024
2 checks passed
@jeffpaul jeffpaul deleted the upkeep/node branch May 14, 2024 13:59
@dkotter dkotter removed this from the 1.8.1 milestone Nov 15, 2024
@dkotter dkotter added this to the 1.9.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up NPM dependencies and update node to v20
4 participants