Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto sync PRs with target branch #281

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

iamdharmesh
Copy link
Member

Description of the Change

PR removes explicitly enabled auto sync PR feature to stop PR syncing.

Reason for disabling this: (until we find a way to handle this better way, want to keep this disabled)

  • It keeps sending notifications from PRs for every sync.
  • GH action not getting triggered for the sync commit, which makes the unknown status of checks on the latest PR commit.

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed - Disabled auto sync pull requests with target branch.

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh requested a review from jeffpaul as a code owner March 11, 2024 17:18
@github-actions github-actions bot added this to the 1.8.0 milestone Mar 11, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Mar 11, 2024
@jeffpaul jeffpaul merged commit 277665f into develop Mar 11, 2024
13 checks passed
@jeffpaul jeffpaul deleted the disable-auto-pr-sync branch March 11, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants