rtl8366_smi: Exclude cpu port from pvid initialization.

[Quallenauge]

It causes errors when probing the device, such as:
[ 2.568059] rtl8367b rtl8367b: using bus lantiq,xrx200-mdio
[ 2.572494] rtl8367b rtl8367b: RTL8367RB chip found
[ 4.041784] rtl8367b rtl8367b: VLAN initialization failed, err=1
[ 4.047809] rtl8367b: probe of rtl8367b failed with error 1

Maybe I missed that one on my last test.

[Quallenauge]

Without the cpu check patch and adding a printk at the position:
printk("rtl8366_set_pvid: port=%d port+1=%d\n",port,port+1);
err = rtl8366_set_pvid(smi, port, (port + 1));
...
I get the following output:
DTS setting: lantiq,exif0:
[ 3.675970] rtl8366_set_pvid: port=0 port+1=1
[ 3.714521] rtl8366_set_pvid: port=1 port+1=2
[ 3.753551] rtl8366_set_pvid: port=2 port+1=3
[ 3.793103] rtl8366_set_pvid: port=3 port+1=4
[ 3.833179] rtl8366_set_pvid: port=4 port+1=5
[ 3.873752] rtl8366_set_pvid: port=5 port+1=6
[ 3.914568] rtl8366_set_pvid: port=6 port+1=7
[ 3.937875] rtl8367b rtl8367b: VLAN initialization failed, err=1
[ 3.942499] rtl8367b: probe of rtl8367b failed with error 1

DTS setting: lantiq,exif1:
[ 3.676044] rtl8366_set_pvid: port=0 port+1=1
[ 3.714592] rtl8366_set_pvid: port=1 port+1=2
[ 3.753629] rtl8366_set_pvid: port=2 port+1=3
[ 3.793190] rtl8366_set_pvid: port=3 port+1=4
[ 3.833264] rtl8366_set_pvid: port=4 port+1=5
[ 3.873839] rtl8366_set_pvid: port=5 port+1=6
[ 3.914654] rtl8366_set_pvid: port=6 port+1=7
[ 3.956276] rtl8366_set_pvid: port=7 port+1=8
[ 3.980067] rtl8367b rtl8367b: VLAN initialization failed, err=1
[ 3.984690] rtl8367b: probe of rtl8367b failed with error 1

DTS setting: lantiq,exif2:
[ 3.675544] rtl8366_set_pvid: port=0 port+1=1
[ 3.714074] rtl8366_set_pvid: port=1 port+1=2
[ 3.753107] rtl8366_set_pvid: port=2 port+1=3
[ 3.792656] rtl8366_set_pvid: port=3 port+1=4
[ 3.832708] rtl8366_set_pvid: port=4 port+1=5
[ 3.873283] rtl8366_set_pvid: port=5 port+1=6
[ 3.896047] rtl8367b rtl8367b: VLAN initialization failed, err=1
[ 3.900672] rtl8367b: probe of rtl8367b failed with error 1

Do I missing something?

[13hakta]

You've found an issue just at the point where I stopped. The point is that driver covers few devices which have different port combinations. R-VB has ext0,ext1 (port 5,6 or ext 0,1), RB has ext1,ext2 (port 7,8 or ext 1,2). That means that on PVID init must be avoided NON-present port. That's where you catch err=1.
While CPU port is not a port must be avoided, there must be another way. I suppose that it could be some kind of port mask or hardware disabling.