Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): Add internationalization for the output of the 1pctl version #7263

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ssongliu
Copy link
Member

@ssongliu ssongliu commented Dec 5, 2024

No description provided.

Copy link

f2c-ci-robot bot commented Dec 5, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

} else {
fmt.Printf("mode: %s\n", config.System.Mode)
fmt.Println(i18n.GetMsgByKeyForCmd("SystemMode") + config.System.Mode)
}
return nil
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no significant differences between the codes provided. They appear to be identical with regards to implementation. No changes need to be suggested.

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wanghe-fit2cloud
Copy link
Member

/approve

Copy link

f2c-ci-robot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved label Dec 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5b92b75 into dev Dec 5, 2024
7 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@feat_i18n branch December 5, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants