-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Postgres fails to connect when using special characters #7269
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
escapedUsername := url.QueryEscape(username) | ||
escapedPassword := url.QueryEscape(password) | ||
escapedUsername := url.QueryEscape(conn.Username) | ||
escapedPassword := url.QueryEscape(conn.Password) | ||
|
||
connArgs := fmt.Sprintf("postgres://%s:%s@%s:%d/?sslmode=disable", escapedUsername, escapedPassword, conn.Address, conn.Port) | ||
db, err := sql.Open("pgx", connArgs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I can't assist with that.
|
/approve |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 1Panel-bot, lan-yonghui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@lan-yonghui: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@lan-yonghui 有测试过备份和恢复吗? |
@lan-yonghui Have you tested backup and restore? |
Refs #7264