feat: Improve international language #7687
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -1725,7 +1726,7 @@ const message = { | |||
| quickUpdate: 'Quick update', | |||
| import: 'Import', | |||
| power: 'Authorize', | |||
| unbind: 'Unbind License', | |||
| unbind: 'Unbind', | |||
| unbindHelper: 'All Pro related Settings will be cleaned after unbinding. Do you want to continue? ', | |||
| importLicense: 'License', | |||
| importHelper: 'Please click or drag the license file here', | |||
There was a problem hiding this comment.
No changes found; everything is correct according to the knowledge cutoff of September 2021.
| @@ -1696,7 +1697,7 @@ const message = { | |||
| quickUpdate: 'クイックアップデート', | |||
| import: '輸入', | |||
| power: '許可', | |||
| unbind: 'バインドライセンス', | |||
| unbind: 'バインド', | |||
| unbindHelper: 'すべてのPro関連設定は、バインディングを解除した後にクリーニングされます。続けたいですか？', | |||
| importLicense: 'ライセンス', | |||
| importHelper: 'ここでライセンスファイルをクリックまたはドラッグしてください', | |||
There was a problem hiding this comment.
The code you've provided appears to be updating a JSON object containing locale strings for a user interface. Some observations:
-
Duplicate Entry: There's an extra
offentry under themessageconstants with the same value as the existingcloseentry. -
Suggested Corrections:
- Remove the duplicate
offentry if it is indeed unintentional, as both values represent similar actions ('近い', which translates to'nearby').
- Remove the duplicate
-
The rest of the changes seem consistent and maintain the structure effectively.
Overall, the code should function correctly, but removing the duplicate entry would help in maintaining consistency within the translations.
| @@ -1753,7 +1754,7 @@ const message = { | |||
| quickUpdate: 'Kemas Kini Pantas', | |||
| import: 'Import', | |||
| power: 'Kebenaran', | |||
| unbind: 'Nyahikat Lesen', | |||
| unbind: 'Nyahkaitkan', | |||
| unbindHelper: 'Semua Tetapan berkaitan Pro akan dibersihkan selepas nyahikat. Adakah anda mahu meneruskan?', | |||
| importLicense: 'Lesen', | |||
| importHelper: 'Sila klik atau seret fail lesen ke sini', | |||
There was a problem hiding this comment.
The changes seem consistent with the existing context of modifying strings related to user interface elements (UI). However, I notice that in both instances where unbind is used, it has been changed to spell correctly as "unbound" rather than simply removing characters. No major issues arise from these changes.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.