Skip to content

Commit

Permalink
Settings clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
1hitsong committed Nov 21, 2024
1 parent 99954fe commit d974d36
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 25 deletions.
2 changes: 1 addition & 1 deletion components/Libraries/VisualLibraryScene.bs
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ sub onItemFocused()

m.star.uri = "pkg:/images/sharp_star_white_18dp.png"

if m.global.session.user.settings["ui.movies.showRatings"]
if m.global.session.user.settings["ui.itemdetail.showRatings"]
if isValid(itemData.communityRating)
setFieldText("communityRating", int(itemData.communityRating * 10) / 10)
m.communityRatingGroup.visible = true
Expand Down
2 changes: 1 addition & 1 deletion components/movies/MovieDetails.bs
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ sub itemContentChanged()

criticRatingIcon = m.top.findNode("criticRatingIcon")

if m.global.session.user.settings["ui.movies.showRatings"]
if m.global.session.user.settings["ui.itemdetail.showRatings"]
if isValid(itemData.communityRating)
m.top.findNode("star").visible = true
setFieldText("communityRating", int(itemData.communityRating * 10) / 10)
Expand Down
33 changes: 10 additions & 23 deletions settings/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,15 @@
"description": "Settings relating to the appearance of the item detail screen.",
"children": [
{
"title": "Show Overview Content",
"description": "If available, show the overview content on the item detail screen",
"title": "Community and Critical Ratings",
"description": "Community and critic review ratings from Rotton Tomatoes.",
"settingName": "ui.itemdetail.showRatings",
"type": "bool",
"default": "true"
},
{
"title": "Overview Content",
"description": "A quick overview of the item selected - typically a short plot outline.",
"settingName": "ui.itemdetail.showoverviewcontent",
"type": "bool",
"default": "true"
Expand Down Expand Up @@ -460,34 +467,14 @@
}
]
},
{
"title": "Movies",
"description": "Settings relating to the appearance of pages in Movie Libraries.",
"children": [
{
"title": "Community and Critical Ratings",
"description": "Ratings for how good a movie is.",
"settingName": "ui.movies.showRatings",
"type": "bool",
"default": "true"
}
]
},
{
"title": "TV Shows",
"description": "Settings relating to the appearance of pages in TV Libraries.",
"children": [
{
"title": "Blur Unwatched Episodes",
"description": "Blur images of unwatched episodes.",
"settingName": "ui.tvshows.blurunwatched",
"type": "bool",
"default": "false"
},
{
"title": "Disable Community Rating for Episodes",
"description": "Hide the star and community rating for episodes of a TV show. This is to prevent spoilers of an upcoming good/bad episode.",
"settingName": "ui.tvshows.disableCommunityRating",
"settingName": "ui.itemdetail.showRatings",
"type": "bool",
"default": "false"
},
Expand Down

0 comments on commit d974d36

Please sign in to comment.