-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev environments #1415
Dev environments #1415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest look good to me
I also want to ask what will be added to this folder? I can imagine that this directory would grow very quickly if we added a new folder for each use case.
Any ideas to manage that? This structure allows having multiple level hierarchy, because each directory is independent with its own Makefile, docker-compose.yaml, etc... It could grow into something like:
|
Initially, I thought we could share common files, but having independent files also has its own advantages. I think it's good as is and if it grows we can always change or move somewhere else later |
yeah, there is some breaking on the DRY patterns. But small makefiles and docker files, not that important IMO. I also wanted to avoid "pollution" in the main Makefile, so I removed some existing dev environments from the main Makefile. Mainly because this can grow.
|
Look good to me as is, I think we can merge this and improve later if we need to |
What
Docker compose based development environment. Looking for easy testing setups for different use cases.
Environments:
dev-environments/listen-tls
dev-environments/https-proxy-upstream-tlsv1.3
dev-environments/http-proxy-plain-http-upstream
dev-environments/opentelemetry-instrumented-gateway
dev-environments/plain-http-upstream
dev-environments/upstream-tlsv1.3
Usually dev environment can run by
cd
-ing to the path and runningmake gateway
. For example:If the environment requires TLS certificates, there is an extra step (Makefile target) to generate on the fly the (self signed) certificates. I have tried to avoid committing certs to github, even if they are fake for
example.com
.