New portal reindex page. #56
Conversation
| def parse_int(value: Optional[str], fallback: int = 0) -> int: | ||
| try: | ||
| return int(value) if value else fallback | ||
| except ValueError: | ||
| return fallback | ||
|
|
||
|
|
||
| def parse_bool(value: Optional[str], fallback: int = 0) -> int: | ||
| try: | ||
| return value.lower() == "true" if value else fallback | ||
| except ValueError: | ||
| return fallback |
There was a problem hiding this comment.
These seem like good candidates for utils in the future
| log_events = logs.get_log_events(logGroupName=log_group, logStreamName=log_stream, startFromHead=True)["events"] | ||
| for log_event in log_events: | ||
| msg = log_event.get("message") | ||
| # The entrypoint_deployment.bash script at least partially | ||
| # creates this log output, which includes a line like this: | ||
| # green: digest: sha256:c1204f9ff576105d9a56828e2c0645cc6dbcf91abca767ef6fe033a60c483f10 size: 7632 | ||
| if msg and "digest:" in msg and "size:" in msg and (not image_tag or f"{image_tag}:" in msg): |
There was a problem hiding this comment.
This could be very long... You might want to start from tail as this build digest will be at the very end right?
There was a problem hiding this comment.
Great idea - I should have thought of that, assumed not supported, but it does seem to be (startFromHead=False)
There was a problem hiding this comment.
I should/will add a comment to this effect but this fetching of the digest is not critical to the functioning of the page - it just gives a nice verification that the most recent build does in fact match the current image.
| # For some reason this (rarely-ish) intermittently fails with no error; | ||
| # the results just do not contain the digest; don't know why so try a few times. |
There was a problem hiding this comment.
No, it happens on successful builds too, it is intermittent, who knows - search from the end like you suggest might help, which I did make that change.
| def get_aws_ecr_build_info(image_repo_or_arn: str, image_tag: Optional[str] = None, previous_builds: int = 2) -> Dict: | ||
| """ | ||
| Returns a dictionary with info about the three most recent CodeBuild builds | ||
| for the given image repo and tag, or None if none found. | ||
| """ |
There was a problem hiding this comment.
This function among others in this module probably belong in utils, something to think about in the future if you have the time
| if len(vpcs) == 1: | ||
| vpc = vpcs[0] | ||
| else: | ||
| vpcs = [item for item in vpcs if "main" in (item.get("name") or "").lower()] |
There was a problem hiding this comment.
You might want to comment that this "main" identifier is very important and specific to our infrastructure code
| const region = "us-east-1"; | ||
|
|
||
| function awsClusterLink(id) { | ||
| return `https://${region}.console.aws.amazon.com/ecs/v2/clusters/${id}/services?region=${region}`; |
There was a problem hiding this comment.
You might want to make the base URL here a constant so if it changes (which it has since we started using ECS) you can update more easily
| { (props.cluster?.env?.is_production || props.cluster?.env?.is_staging || props.cluster?.env?.color) && | ||
| <small style={{float: "right", color: props.cluster?.env?.color == "blue" ? "blue" : (props.cluster?.env?.color == "green" ? "green" : "")}} onClick={toggleShowDetail}> | ||
| {props.cluster?.env?.is_production && <b>PRODUCTION</b>} | ||
| {props.cluster?.env?.is_staging && <b>STAGING</b>} | ||
| {props.cluster?.env?.color && <> | ||
| ({props.cluster?.env?.color?.toUpperCase()}) | ||
| </>} | ||
| </small> | ||
| } |
There was a problem hiding this comment.
Are we handling the standalone case cleanly as well?
| </td></tr></tbody></table> | ||
| { isShowUpdatingWarning() && (!isShowUpdatingButton() || confirmed) && !runResult && <small style={{color: "red"}}> | ||
| <SeparatorH color="red" /> | ||
| <b>Warning</b>: A cluseter update appears to be already <u><b>running</b></u>. Run this <u><b>only</b></u> if you know what you are doing! |
react/src/pages/PortalReindexPage.js
Outdated
| const region = "us-east-1"; | ||
|
|
||
| function awsTaskRunLink(id) { | ||
| return `https://${region}.console.aws.amazon.com/ecs/v2/task-definitions/${id}/run-task`; |
There was a problem hiding this comment.
Same comment re constants as in the last file
| const taskNames = [ | ||
| { name: "deploy", label: "Reindex" }, | ||
| { name: "deploy_initial", label: "Initial Deploy" }, | ||
| { name: "indexer", label: "Indexer" }, | ||
| { name: "ingester", label: "Ingester" }, | ||
| { name: "portal", label: "Instance" } | ||
| ]; |
There was a problem hiding this comment.
These map directly to values in Python, should probably be noted (and made constants in the back-end as well)
There was a problem hiding this comment.
Made this driven by table of regex and put in only module (aws_ecs_types.py) for easy finding.
No description provided.