Remove dashboard from profile dialog (#6113)

4ian · Dec 21, 2023 · 5a2a389 · 5a2a389
1 parent 0a6b0dc
commit 5a2a389
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 97 deletions.
diff --git a/newIDE/app/src/AssetStore/AssetPackInstallDialog.js b/newIDE/app/src/AssetStore/AssetPackInstallDialog.js
@@ -247,12 +247,10 @@ const AssetPackInstallDialog = ({
           onApply: () => {},
           content: (
             <AlertMessage kind="warning">
-              <Text>
-                <Trans>
-                  You need to save this project as a cloud project to install
-                  premium assets. Please save your project and try again.
-                </Trans>
-              </Text>
+              <Trans>
+                You need to save this project as a cloud project to install
+                premium assets. Please save your project and try again.
+              </Trans>
             </AlertMessage>
           ),
         }
@@ -270,13 +268,11 @@ const AssetPackInstallDialog = ({
           onApply: () => {},
           content: (
             <AlertMessage kind="warning">
-              <Text>
-                <Trans>
-                  You can only install up to {MAX_ASSETS_TO_INSTALL} assets at
-                  once. Try filtering the assets you would like to install, or
-                  install them one by one.
-                </Trans>
-              </Text>
+              <Trans>
+                You can only install up to {MAX_ASSETS_TO_INSTALL} assets at
+                once. Try filtering the assets you would like to install, or
+                install them one by one.
+              </Trans>
             </AlertMessage>
           ),
         }

diff --git a/newIDE/app/src/Profile/CurrentUsageDisplayer.js b/newIDE/app/src/Profile/CurrentUsageDisplayer.js
@@ -45,11 +45,9 @@ const CurrentUsageDisplayer = ({
   return (
     <ColumnStackLayout noMargin>
       <AlertMessage kind="info">
-        <Text>
-          {remainingBuilds === 1
-            ? remainingSingleMessage
-            : remainingMultipleMessage}
-        </Text>
+        {remainingBuilds === 1
+          ? remainingSingleMessage
+          : remainingMultipleMessage}
       </AlertMessage>
       {hasSubscription && quota.limitReached && (
         <GetSubscriptionCard subscriptionDialogOpeningReason="Build limit reached">

diff --git a/newIDE/app/src/Profile/ProfileDialog.js b/newIDE/app/src/Profile/ProfileDialog.js
@@ -12,7 +12,6 @@ import SubscriptionDetails from './Subscription/SubscriptionDetails';
 import ContributionsDetails from './ContributionsDetails';
 import UserAchievements from './Achievement/UserAchievements';
 import AuthenticatedUserContext from './AuthenticatedUserContext';
-import GamesList from '../GameDashboard/GamesList';
 import { getRedirectToSubscriptionPortalUrl } from '../Utils/GDevelopServices/Usage';
 import Window from '../Utils/Window';
 import { showErrorBox } from '../UI/Messages/MessageBox';
@@ -21,11 +20,6 @@ import PlaceholderLoader from '../UI/PlaceholderLoader';
 import useIsElementVisibleInScroll from '../Utils/UseIsElementVisibleInScroll';
 import { markBadgesAsSeen as doMarkBadgesAsSeen } from '../Utils/GDevelopServices/Badge';
 import ErrorBoundary from '../UI/ErrorBoundary';
-import PlaceholderError from '../UI/PlaceholderError';
-import useGamesList from '../GameDashboard/UseGamesList';
-import { type Game } from '../Utils/GDevelopServices/Game';
-import { GameDetailsDialog } from '../GameDashboard/GameDetailsDialog';
-import { ColumnStackLayout } from '../UI/Layout';
 import AlertMessage from '../UI/AlertMessage';
 
 export type ProfileTab = 'profile' | 'games-dashboard';
@@ -40,20 +34,10 @@ const ProfileDialog = ({ currentProject, open, onClose }: Props) => {
   const badgesSeenNotificationTimeoutRef = React.useRef<?TimeoutID>(null);
   const badgesSeenNotificationSentRef = React.useRef<boolean>(false);
 
-  const [openedGame, setOpenedGame] = React.useState<?Game>(null);
   const [currentTab, setCurrentTab] = React.useState<ProfileTab>('profile');
   const authenticatedUser = React.useContext(AuthenticatedUserContext);
   const isUserLoading = authenticatedUser.loginState !== 'done';
   const userAchievementsContainerRef = React.useRef<?HTMLDivElement>(null);
-  const {
-    games,
-    gamesFetchingError,
-    onGameUpdated,
-    fetchGames,
-  } = useGamesList();
-
-  const projectUuid = currentProject ? currentProject.getProjectUuid() : null;
-
   const markBadgesAsSeen = React.useCallback(
     (entries: IntersectionObserverEntry[]) => {
       if (!(authenticatedUser.authenticated && authenticatedUser.profile)) {
@@ -134,16 +118,6 @@ const ProfileDialog = ({ currentProject, open, onClose }: Props) => {
     [authenticatedUser.onRefreshUserProfile, open] // eslint-disable-line react-hooks/exhaustive-deps
   );
 
-  // Only fetch games if the user decides to open the games dashboard tab.
-  React.useEffect(
-    () => {
-      if (currentTab === 'games-dashboard' && !games) {
-        fetchGames();
-      }
-    },
-    [fetchGames, currentTab, games]
-  );
-
   const onLogout = React.useCallback(
     async () => {
       await authenticatedUser.onLogout();
@@ -242,33 +216,16 @@ const ProfileDialog = ({ currentProject, open, onClose }: Props) => {
               </Column>
             </Line>
           )}
-          {currentTab === 'games-dashboard' &&
-            (games ? (
-              <ColumnStackLayout>
-                <AlertMessage kind="info">
-                  <Trans>
-                    You can find the Games Dashboard on the home page under the
-                    Manage tab.
-                  </Trans>
-                </AlertMessage>
-                <GamesList
-                  project={currentProject}
-                  onRefreshGames={fetchGames}
-                  games={games}
-                  onGameUpdated={onGameUpdated}
-                  onOpenGame={setOpenedGame}
-                />
-              </ColumnStackLayout>
-            ) : gamesFetchingError ? (
-              <PlaceholderError onRetry={fetchGames}>
+          {currentTab === 'games-dashboard' && (
+            <Column expand justifyContent="center" alignItems="center">
+              <AlertMessage kind="info">
                 <Trans>
-                  Can't load the games. Verify your internet connection or retry
-                  later.
+                  You can now find the Games Dashboard on the home page under
+                  the Manage tab.
                 </Trans>
-              </PlaceholderError>
-            ) : (
-              <PlaceholderLoader />
-            ))}
+              </AlertMessage>
+            </Column>
+          )}
         </>
       ) : (
         <Column noMargin expand justifyContent="center">
@@ -287,28 +244,6 @@ const ProfileDialog = ({ currentProject, open, onClose }: Props) => {
           />
         </Column>
       )}
-      {openedGame && (
-        <GameDetailsDialog
-          game={openedGame}
-          project={
-            !!projectUuid && openedGame.id === projectUuid
-              ? currentProject
-              : null
-          }
-          onClose={() => {
-            setOpenedGame(null);
-          }}
-          onGameUpdated={updatedGame => {
-            onGameUpdated(updatedGame);
-            setOpenedGame(updatedGame);
-          }}
-          onGameDeleted={() => {
-            setOpenedGame(null);
-            fetchGames();
-          }}
-          analyticsSource="profile"
-        />
-      )}
     </Dialog>
   );
 };

diff --git a/newIDE/app/src/UI/ErrorBoundary.js b/newIDE/app/src/UI/ErrorBoundary.js
@@ -207,12 +207,10 @@ export const ErrorFallbackComponent = ({
         <Divider />
         <ColumnStackLayout>
           <AlertMessage kind={isCriticalError ? 'error' : 'warning'}>
-            <Text>
-              <Trans>
-                Please <b>backup your game file</b> and save your game to ensure
-                that you don't lose anything.
-              </Trans>
-            </Text>
+            <Trans>
+              Please <b>backup your game file</b> and save your game to ensure
+              that you don't lose anything.
+            </Trans>
           </AlertMessage>
           <Text>
             <Trans>