Fix possible crash in the New Object Dialog (#5968)

4ian · Nov 28, 2023 · 6cd8f54 · 6cd8f54
1 parent 9718fb7
commit 6cd8f54
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js b/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js
@@ -237,7 +237,8 @@ const InstructionParametersEditor = React.forwardRef<
       objectName
     );
 
-    const iconFilename = instructionMetadata.getIconFilename();
+    // For some reason, iconFileName can sometimes be undefined. see https://github.com/4ian/GDevelop/issues/5958.
+    const iconFilename = instructionMetadata.getIconFilename() || '';
     const shouldInvertGrayScale =
       paletteType === 'dark' &&
       (iconFilename.startsWith('data:image/svg+xml') ||
@@ -251,7 +252,7 @@ const InstructionParametersEditor = React.forwardRef<
             <Column expand>
               <Line alignItems="flex-start">
                 <img
-                  src={instructionMetadata.getIconFilename()}
+                  src={iconFilename}
                   alt=""
                   style={{
                     ...styles.icon,