Fix 3D light rotation angle calculus when Y is the top (#6004)

- In order to get back the same light result as before, 27° should be subtracted to the rotation angle.
4ian · Dec 4, 2023 · ed46356 · ed46356
1 parent b6f25db
commit ed46356
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Extensions/3D/DirectionalLight.ts b/Extensions/3D/DirectionalLight.ts
@@ -93,7 +93,7 @@ namespace gdjs {
               this.rotationObject.rotation.y = -gdjs.toRad(this.elevation);
             } else {
               // 0° becomes a light from Z+.
-              this.rotationObject.rotation.y = gdjs.toRad(this.rotation) - 90;
+              this.rotationObject.rotation.y = gdjs.toRad(this.rotation - 90);
               this.rotationObject.rotation.z = -gdjs.toRad(this.elevation);
             }
           }

diff --git a/Extensions/3D/HemisphereLight.ts b/Extensions/3D/HemisphereLight.ts
@@ -98,7 +98,7 @@ namespace gdjs {
               this.rotationObject.rotation.y = -gdjs.toRad(this.elevation);
             } else {
               // 0° becomes a light from Z+.
-              this.rotationObject.rotation.y = gdjs.toRad(this.rotation) - 90;
+              this.rotationObject.rotation.y = gdjs.toRad(this.rotation - 90);
               this.rotationObject.rotation.z = -gdjs.toRad(this.elevation);
             }
           }