Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The branding option does not work. & GDevelop logo to. #5859

Closed
1 task done
AlexMasterbober opened this issue Oct 31, 2023 · 17 comments · Fixed by #5864
Closed
1 task done

The branding option does not work. & GDevelop logo to. #5859

AlexMasterbober opened this issue Oct 31, 2023 · 17 comments · Fixed by #5864
Labels
🐛 bug This is a bug impacting users

Comments

@AlexMasterbober
Copy link

Is there an existing issue for this?

Describe the bug

after the upgrade to 5.2.179 - all types of logo and branding have stopped working.
I see in Desktop & in Web platforms - everyware the same bug. All kind of logo does not working. It just doesn't appear.
gdevelop_logo bug

and i tested in web platform in one of the exaples - and it doesn't work to. So problem not in my platform.

in version 5.2.176 it works.

Steps to reproduce

  1. Go to Game settings
  2. Properties
  3. Load the background image or turn on Gdevelop Logo
  4. It just doesn't appear in preview and final HTML5 (empty)

GDevelop platform

Desktop

GDevelop version

5.3.179 (editor full version: 5.3.179-e0df9b0ff39dcea7a28e6baeb1de814b8acd3399, core version: 4.0.99-0-release)

Platform info

Windows 10 Pro, 21H2

Additional context

No response

@AlexMasterbober
Copy link
Author

I solved the problem by replacing the file "pixi-image-manager.js" (in HTML5 game) from the previous compilation with version 5.2.176. Everything seems to be ok. Maybe this information will help you solve the problem faster.

@Silver-Streak Silver-Streak added the 🐛 bug This is a bug impacting users label Nov 2, 2023
@AlexandreSi
Copy link
Collaborator

Thanks for the report and sorry for the inconvenience, this is quite unexpected.
I'll have a look!

@AlexandreSi
Copy link
Collaborator

I can reproduce the fact that a custom logo is not displayed but the GDevelop logos are working fine for me.
If GDevelop logos do not display, could you open the develop tools (Ctrl + Shift + i) in the preview and see if there are any messages there?

@AlexMasterbober
Copy link
Author

Logo GDevelop not working on my platform.
image

@AlexMasterbober
Copy link
Author

image

@AlexMasterbober
Copy link
Author

in last version all works. But in Console we have this:
This is screen for my last version compilation (in 5.2.176)
Maybe it halps. Look in file "pixi-image-manager.js" it differs from the previous compiled version

image

@AlexandreSi
Copy link
Collaborator

Logo GDevelop not working on my platform.

Once the console is opened, please hit refresh (Ctrl + R) to reload the game and get all the messages starting from the game initialization. We should see more data

@AlexandreSi AlexandreSi reopened this Nov 2, 2023
@AlexMasterbober
Copy link
Author

image

@AlexandreSi
Copy link
Collaborator

Could you send us your project to see if the same issue happens on our devices?

@AlexMasterbober
Copy link
Author

Everything works with this file:
pixi-image-manager(5.2.176).zip

But not with this one:
pixi-image-manager(5.2.179).zip

@AlexMasterbober
Copy link
Author

AlexMasterbober commented Nov 2, 2023

No need. I created a new compiled WEB and looked in the browser - the GDEVELOP logo works there. I also tested my project in with the GDEVELOP logo and without my logo in the browser too. It's just that the Gdevelop logo is not visible in the preview. So only my logo doesn't work.

@AlexandreSi
Copy link
Collaborator

Ok so I'm closing this issue, I'll reopen it if we see others encounter the same issue.

@AlexMasterbober
Copy link
Author

No. So the branded logo does not work. Don't you want to fix it?

@AlexMasterbober
Copy link
Author

This option not working at all. Ned to fix it.
image

@AlexandreSi
Copy link
Collaborator

AlexandreSi commented Nov 2, 2023

Regarding your custom background, the issue is fixed.
Regarding GDevelop logos, I can't reproduce the issue so I can't continue on this topic. We'll see if others complain.

@AlexMasterbober
Copy link
Author

Great. Will this issue be fixed in the next update? or just download the same version again?

@AlexandreSi
Copy link
Collaborator

In the next update that should be released soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug impacting users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants