Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to force loading of texture #5864

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Conversation

AlexandreSi
Copy link
Collaborator

Fixes #5859

When cleaning Pixi image manager, I forgot that we could need textures before the splash screen has finished loading.
This should fix it. I don't think we would need this somewhere else.

@AlexandreSi AlexandreSi requested a review from 4ian as a code owner November 2, 2023 09:39
Copy link
Collaborator

@ClementPasteau ClementPasteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I suppose you've tested it works again with a custom loading screen?

@AlexandreSi AlexandreSi merged commit d945426 into master Nov 2, 2023
@AlexandreSi AlexandreSi deleted the fix-spash-screen branch November 2, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The branding option does not work. & GDevelop logo to.
2 participants