Improvement features for Input text box #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouh
reviewed
Jan 14, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 20, 2025
AlexandreSi
reviewed
Jan 21, 2025
AlexandreSi
reviewed
Jan 21, 2025
| 'rotate3d(0,0,1,' + (this._object.getAngle() % 360) + 'deg)'; | ||
| this._input.style.padding = this._object.getPadding() + 'px'; |
There was a problem hiding this comment.
I think the padding should have a minimum of 0, otherwise you might have some weird results
There was a problem hiding this comment.
Maybe it should be handled in the method getPadding directly
AlexandreSi
reviewed
Jan 21, 2025
AlexandreSi
reviewed
Jan 21, 2025
AlexandreSi
reviewed
Jan 21, 2025
AlexandreSi
reviewed
Jan 21, 2025
4ian
reviewed
Jan 21, 2025
| @@ -113,7 +131,10 @@ namespace gdjs { | |||
| this._borderWidth = objectData.content.borderWidth; | |||
| this._disabled = objectData.content.disabled; | |||
| this._readOnly = objectData.content.readOnly; | |||
|
|
|||
| this._padding = objectData.content.padding || 0; | |||
4ian
reviewed
Jan 21, 2025
AlexandreSi
reviewed
Jan 22, 2025
AlexandreSi
reviewed
Jan 22, 2025
AlexandreSi
reviewed
Jan 22, 2025
AlexandreSi
reviewed
Jan 22, 2025
AlexandreSi
reviewed
Jan 22, 2025
AlexandreSi
reviewed
Jan 22, 2025
… value. Fixed padding issue on pixi renderer
AlexandreSi
reviewed
Jan 22, 2025
Co-authored-by: AlexandreS <[email protected]>
AlexandreSi
reviewed
Jan 22, 2025
Co-authored-by: AlexandreS <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding and maxLength are working as they should right now. They dont affect the editor render, but they work when you launch the game. Text align does not. It is based on the functionnement of 'InputTypes' properties, on my copy, it always align on the right. I tried to hardcode it left in textinputruntimeobject.ts on line 38, in jsExtension.js line 256 and line 692