Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict between variable or property and parameter in variable setters #7329

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Jan 20, 2025

Context

  • An identifier in a "Set variable value" action matches an extension scene variable and a parameter at the same time

Actual

  • A parameter getter is generated as if it where a variable and it crashes at preview
  • The event sheet displays a parameter icon for the variable field

Expected

  • A scene variable getter is generated (as parameter can't be used in actions)
  • The event sheet displays an extension scene variable icon for the variable field

Note that, in both cases, a non-fatal error will appear in the event sheet for the conflict with the parameter (the error message is not displayed anywhere because the VariableField don't display ExpressionValidator errors)

@D8H D8H requested a review from 4ian as a code owner January 20, 2025 18:04
@D8H D8H force-pushed the fix-variable-setter branch from d4240bc to 4840972 Compare January 20, 2025 18:13
@D8H D8H force-pushed the fix-variable-setter branch from 847a6a3 to 05f4133 Compare January 21, 2025 10:13
@D8H D8H merged commit d08bf97 into master Jan 21, 2025
5 of 6 checks passed
@D8H D8H deleted the fix-variable-setter branch January 21, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants