Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder_contents listing in the @listing-custom-fields endpoint #8119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Abdu-moustafa
Copy link
Contributor

@Abdu-moustafa Abdu-moustafa commented Jan 28, 2025

This PR:

  • Provides a new slot in the ListingCustomFieldsGet endpoint for folder_contents.
  • Excludes dossier assignment from the property sheet when the workspace is active."

For TI-1895

Checklist

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

Only applicable should be left and checked.

  • Upgrade-Steps:
    • SQL Operations do not use imported model (see docs)
    • Make it deferrable if possible
    • Execute as much as possible conditionally
    • DB-Schema migration
      • All changes on a model (columns, etc) are included in a DB-schema migration.
      • Constraint names are shorter than 30 characters (Oracle)
  • API change:
    • Documentation is updated
    • API Changelog entry (see guide)
    • If breaking:
      • api-change label added
      • #delivery channel notified about breaking change
      • Scrum master is informed
  • Bug fixed:
    • Resolved any Sentry issues caused by this bug
  • New functionality:
    • for document also works for mail
    • for task also works for forwarding
  • Further improvements needed:
    • Create follow-up stories and link them in the PR and Jira issue
  • Change could impact client installations, client policies need to be adapted
  • New translations
    • All msg-strings are unicode
  • Change in schema definition:
    • If missing_value is specified, then default has to be set to the same value

@Abdu-moustafa Abdu-moustafa force-pushed the amo/TI-1895/user_predefined_fields_teamraum branch 4 times, most recently from ae36387 to ca20994 Compare January 29, 2025 09:52
@Abdu-moustafa Abdu-moustafa marked this pull request as ready for review January 29, 2025 10:14
Copy link
Member

@elioschmutz elioschmutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good in general

Please separate your commit into two commits. The first commit should add the folder_content listing to the @listing-custom-fields endpoint. The changelog of this commit should be of type .feature and requires an entry in the api-changelog.

The second commit should contain the change where you restrict the assignment slots for teamraum. This commit requires a changelog of type .other without an entry in the api-changelog.

Remember to rename the commit to accurately reflect the changes made in the related commit.

Please, also update the PR title to the main purpose of the PR. Excluding the dossier assignment is just something you have to do that everything works as expected. The main purpose of this PR is to provide the folder_contents listing in the @listing-custom-fields endpoint. The PR description should reflect that and the focus should be on the feature.

opengever/propertysheets/definition.py Outdated Show resolved Hide resolved
@Abdu-moustafa Abdu-moustafa force-pushed the amo/TI-1895/user_predefined_fields_teamraum branch from ca20994 to 45991ec Compare January 30, 2025 10:20
@Abdu-moustafa Abdu-moustafa changed the title exclude dossier assignment from propertysheet when workspace active Add folder_contents listing in the @listing-custom-fields endpoint Jan 30, 2025
Copy link
Member

@elioschmutz elioschmutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changes/TI-1895.feature Outdated Show resolved Hide resolved
changes/TI-1895.other Outdated Show resolved Hide resolved
opengever/propertysheets/definition.py Outdated Show resolved Hide resolved
@Abdu-moustafa Abdu-moustafa force-pushed the amo/TI-1895/user_predefined_fields_teamraum branch from 45991ec to 2aed98a Compare January 30, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants