-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folder_contents listing in the @listing-custom-fields endpoint #8119
base: master
Are you sure you want to change the base?
Conversation
ae36387
to
ca20994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good in general
Please separate your commit into two commits. The first commit should add the folder_content
listing to the @listing-custom-fields
endpoint. The changelog of this commit should be of type .feature
and requires an entry in the api-changelog
.
The second commit should contain the change where you restrict the assignment slots for teamraum. This commit requires a changelog of type .other
without an entry in the api-changelog
.
Remember to rename the commit to accurately reflect the changes made in the related commit.
Please, also update the PR title to the main purpose of the PR. Excluding the dossier assignment is just something you have to do that everything works as expected. The main purpose of this PR is to provide the folder_contents
listing in the @listing-custom-fields
endpoint. The PR description should reflect that and the focus should be on the feature.
ca20994
to
45991ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
45991ec
to
2aed98a
Compare
This PR:
For TI-1895
Checklist
Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.
Only applicable should be left and checked.
Oracle
)document
also works formail
task
also works forforwarding
missing_value
is specified, thendefault
has to be set to the same value