Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config refactoring #2040

Merged
merged 10 commits into from
Nov 18, 2023
Merged

Config refactoring #2040

merged 10 commits into from
Nov 18, 2023

Conversation

pshirshov
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Merging #2040 (f8ab0aa) into develop (45fedd6) will increase coverage by 0.02%.
The diff coverage is 82.83%.

❗ Current head f8ab0aa differs from pull request most recent head 4f94831. Consider uploading reports for the commit 4f94831 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2040      +/-   ##
===========================================
+ Coverage    66.50%   66.53%   +0.02%     
===========================================
  Files          546      549       +3     
  Lines        10955    10982      +27     
===========================================
+ Hits          7286     7307      +21     
- Misses        3669     3675       +6     

@pshirshov pshirshov marked this pull request as ready for review November 17, 2023 21:26
@pshirshov pshirshov requested a review from neko-kai as a code owner November 17, 2023 21:26
@pshirshov pshirshov enabled auto-merge (squash) November 17, 2023 21:28
@pshirshov pshirshov merged commit 4e5f4cb into develop Nov 18, 2023
24 of 26 checks passed
@pshirshov pshirshov deleted the wip/config-refactoring branch November 18, 2023 03:36
neko-kai added a commit that referenced this pull request Nov 21, 2023
…ment merging for memoization regression introduced in #2040
neko-kai added a commit that referenced this pull request Nov 21, 2023
Exclude new AppConfig fields from equals/hashCode to fix test environment merging for memoization regression introduced in #2040
neko-kai added a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants