Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel funding plugin #11

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add channel funding plugin #11

merged 2 commits into from
Feb 28, 2024

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Feb 20, 2024

Add a plugin showcasing how incoming channel requests can be intercepted to let node operators apply restrictions on what channels they accept.

This can also be used to leverage dual funding to make sure channels are immediately funded on both sides.

Co-authored with @remyers: I forked #4 to add the dual-funding part, based on ACINQ/eclair#2829

Add a plugin showcasing how incoming channel requests can be intercepted
to let node operators apply restrictions on what channels they accept.

This can also be used to leverage dual funding to make sure channels are
immediately funded on both sides.

Co-authored with @remyers
@t-bast t-bast requested a review from remyers February 20, 2024 17:15
Copy link

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran also ran some tests in lightning-cfg to exercise the plugin and it worked as advertised.

Just a couple of small nit, but otherwise looks good.

channel-funding/README.md Outdated Show resolved Hide resolved
To invert the meaning to reject-private-nodes.
Copy link

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-bast t-bast merged commit 59a7cc9 into master Feb 28, 2024
@t-bast t-bast deleted the channel-funder-plugin branch February 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants