WIP: Electron tests & cooling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 14, 2021 17:06
…into feature/electrons-tests
…into feature/electrons-tests
…plyHeating calling convention to acommodate driven turbulence problem.
…ter applying any primitive source terms
This is 90% straight merge, see prior commit msgs. It adds FFTW as an optional dependency within CMake, using the FindFFTW.cmake file from the Eigen linear algebra library. It also adds some license/header/option cleanup. This has NOT been tested to still PASS the e- tests!
|
Closing in favor of a version ported forward from excellent work by Cesar Diaz |
added 8 commits
January 5, 2023 10:42
…plyHeating calling convention to acommodate driven turbulence problem.
…ain of interest 0 to 1
cooling is now only applied at last step, operator splitting
added 7 commits
January 9, 2023 13:54
…ure/electrons-tests
|
Going to pull this for the existing improvements so it doesn't fall out of date again. Missing tests have been added to #52 and cooling is for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes are now in dev for electron heating when applying floors; however, before we run with electron models at scale, there should be a few more tests in place first.