Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added name and details to the Readme file (rawalvarun) #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added name and details to the Readme file (rawalvarun) #98

wants to merge 2 commits into from

Conversation

rawalvarun
Copy link

Added the details in the specified format.
Name git-username

@abinashmeher999
Copy link
Member

Can you improve the commit message to reflect what was added? Like Added Varun Rawal to README. You will also have to rebase on top of master so that I can merge it.

@abinashmeher999
Copy link
Member

And squash the commits too, you don't need two commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Need Better Commit Message Need History cleanup Need rebase on latest master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawalvarun @abinashmeher999