Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing triage labels #49

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Add missing triage labels #49

merged 2 commits into from
Feb 28, 2022

Conversation

codificat
Copy link
Member

The AICoE repos are missing a couple of labels that are used for issue triage: needs-triage and triage/accepted.

Example issues showing that gap in action include AICoE/manage-dependencies-tutorial#25 (comment), AICoE/sefkhet-abwy#184 (comment), AICoE/aicoe-ci#153 (comment)

This PR adds these two labels.

@sesheta sesheta requested review from goern and harshad16 February 16, 2022 11:38
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2022
harshad16
harshad16 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@goern
Copy link
Member

goern commented Feb 21, 2022

/approve

@sesheta
Copy link

sesheta commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@codificat
Add missing triage/accepted label
ea39bf5 
Signed-off-by: Pep Turró Mauri <[email protected]>
@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2022
@codificat
Copy link
Member Author

Updated to only add the triage/accepted label.

The needs-triage label is meant to be managed by a dedicated prow plugin which is currently not configured to act on any of the repos in the AICoE github org (ref thoth-station/thoth-application#2359 (comment) and https://github.com/thoth-station/thoth-application/blob/620b649dc4c67c8cb9f926feb3c6b53ccd355e64/prow/overlays/smaug/plugins.yaml#L45)

@codificat
Copy link
Member Author

/retest

@codificat
Fix label_sync command
2c31171 
Signed-off-by: Pep Turró Mauri <[email protected]>
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2022
@codificat
Copy link
Member Author

/test labels

@codificat
Copy link
Member Author

This needs an /lgtm from @goern or @tumido

Note that I also included a fix for the path change in the label_sync image (same as open-services-group/community#84, ref https://github.com/kubernetes/test-infra/blob/198fd8ef3d2441af01a0fad802ec9809b162e599/prow/ANNOUNCEMENTS.md?plain=1#L195)

@harshad16
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@sesheta sesheta merged commit 1c391e2 into AICoE:main Feb 28, 2022
@codificat codificat deleted the triage-labels branch February 28, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@goern goern Awaiting requested review from goern

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codificat @goern @sesheta @harshad16