Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RelationRange a proper view #727

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Make RelationRange a proper view #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/podio/RelationRange.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ifndef PODIO_RELATIONRANGE_H
#define PODIO_RELATIONRANGE_H

#include <iterator>
#include <ranges>
#include <vector>

namespace podio {
Expand Down Expand Up @@ -57,4 +57,11 @@ class RelationRange {
};
} // namespace podio

// Opt-in to view concept
template <typename ReferenceType>
inline constexpr bool std::ranges::enable_view<podio::RelationRange<ReferenceType>> = true;
// Opt-in to borrowed_range concept
template <typename ReferenceType>
inline constexpr bool std::ranges::enable_borrowed_range<podio::RelationRange<ReferenceType>> = true;

#endif // PODIO_RELATIONRANGE_H
13 changes: 13 additions & 0 deletions tests/unittests/std_interoperability.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
#include "datamodel/ExampleHit.h"
#include "datamodel/ExampleHitCollection.h"
#include "datamodel/MutableExampleHit.h"

#include "podio/LinkCollection.h"
#include "podio/RelationRange.h"

#include <catch2/catch_test_macros.hpp>

Expand Down Expand Up @@ -1195,5 +1197,16 @@ TEST_CASE("LinkCollection and range concepts", "[links][iterator][std]") {
STATIC_REQUIRE(std::ranges::viewable_range<link_collection>);
}

TEST_CASE("RelationRange as range", "[relations][ranges][std]") {
using relation_range = podio::RelationRange<ExampleHit>;

STATIC_REQUIRE(std::ranges::contiguous_range<relation_range>);
STATIC_REQUIRE(std::ranges::sized_range<relation_range>);
STATIC_REQUIRE(std::ranges::common_range<relation_range>);
STATIC_REQUIRE(std::ranges::viewable_range<relation_range>);
STATIC_REQUIRE(std::ranges::view<relation_range>);
STATIC_REQUIRE(std::ranges::borrowed_range<relation_range>);
}

#undef DOCUMENTED_STATIC_FAILURE
#undef DOCUMENTED_FAILURE
Loading